Re: [PATCH 6/13] maps: Move the page walker code to lib/

Nick Piggin
2007-04-05T01:50:18Z

Nick Piggin wrote:
> Matt Mackall wrote:
>
>> On Wed, Apr 04, 2007 at 03:50:56PM +1000, Nick Piggin wrote:

>>> Just put it in its own file in mm/ rather than its own file in lib.
>>> lib should be for almost-standalone stuff, IMO (ie. only using basic
>>> kernel functionality).
>>
>>
>>
>> Arguably that's what lib/ should be for, but it's currently largely
>
>
> I disagree. There is code everywhere that exists to provide some
> functionality via an API to other parts of the kernel. You don't
> think mm/page_alloc.c should go in lib/?

Oh, I think I misunderstood you.

Anyway, we have lots of conditionally compiled code in mm as well.
It doesn't seem to be much hardship.

--
SUSE Labs, Novell Inc.