From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADB94428832 for ; Tue, 20 Jan 2026 12:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768913912; cv=pass; b=rgUMrzgaU5KqhCpbAX76WmVVud0UYwNoT5AMiwa+Yde1U+1S7S+etFXJQ+gM4SZwE4ODOHwh7qdV0HXFpyETXIUT0ZLUQ665ciWhXw+rEPnKiGUPODrk3LqqQY+HMTWOt3ZOXGf5MfVE1VgKlbc1rMMoropzdGOH95OKKb72nnE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768913912; c=relaxed/simple; bh=A2a5346Sdj36kn6/komR8GMzyZfYgLKsVr5PMxvz60g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=A6WBKeKjRA2w9EsOqgjDvCG59AcwxJYDLnK2gAhPtQTK1dpH5PdIEBdW9A218o0iOrS/M9zNL5iWzHxTPqPsX8E+YwGCB7AErfWUQpKmzbUe8Cp+8HiDRWNBO8lRXQ7HUvQHMNol//nb5R7qUb7wwN8gDc4iWqoyvSqpWohoTcg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=NK/JAsH+; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="NK/JAsH+" ARC-Seal: i=1; a=rsa-sha256; t=1768913885; cv=none; d=zohomail.com; s=zohoarc; b=PsnqqzEcbPifRlGdx2Mtiwp9QIgJxsvDHp/ZUgjFSzdf16ql8xhGcvuT7NKQKC+G5q+lGFJ0OOYQk74z4on554+oPqkYzVhN7gZBycbjOH4uZ7plFo3FRPd46d7BTY5TtvU1hYd+vt/p5P5PBTmxQLrHTkZoW7WGdmZSjzrn3RY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768913885; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=3YJ9HNhhdVjpjd8lpyfVaHQErXsbBsLle1p3eCQvHXI=; b=RDAs0x08RWqlRZF1mmpSh6vZdyCn8FH975Uj7+lx2elZQ/4md4lekQigs7NvigAXn2DmnjZEwGXp8tW8cUW43XHvuF4a2OrIaN3XOS4Ib5lCeLCPAS5I9gP190qXnoZljsfwhtb1122y6TEGXbrwPswel1AyPOMbnQoYsgGtpSg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768913885; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=3YJ9HNhhdVjpjd8lpyfVaHQErXsbBsLle1p3eCQvHXI=; b=NK/JAsH+4qv3kpUeu7xptAvVuI5rJxqbU4m6klJPYdjIOGp+dnkyjzN/CyfJuz4e 9qI0BrUH9vpa0kbt2888+9Hauk0o7DsTe72m7VGk72jhNYR0UxtCjdpl6uhgHh/Xm01 518BOyMsxCdTsWZcGoTNNOTQjdgKdlftHFJp5yRY= Received: by mx.zohomail.com with SMTPS id 1768913883065871.0979621537674; Tue, 20 Jan 2026 04:58:03 -0800 (PST) From: Nicolas Frattaroli To: Sandy Huang , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Thomas Zimmermann Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Stone Subject: Re: [PATCH v2 1/8] drm/rockchip: vop2: Switch impossible format conditional to WARN_ON Date: Tue, 20 Jan 2026 13:57:56 +0100 Message-ID: <13000903.O9o76ZdvQC@workhorse> In-Reply-To: References: <20251206-vop2-atomic-fixups-v2-0-7fb45bbfbebd@collabora.com> <20251206-vop2-atomic-fixups-v2-1-7fb45bbfbebd@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Tuesday, 20 January 2026 13:49:12 Central European Standard Time Thomas Zimmermann wrote: > Hi > > Am 06.12.25 um 21:45 schrieb Nicolas Frattaroli: > > From: Daniel Stone > > > > We should never be able to create a framebuffer with an unsupported > > format, so throw a warning if this ever happens, instead of attempting > > to stagger on. > > > > Signed-off-by: Daniel Stone > > Signed-off-by: Nicolas Frattaroli > > --- > > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > > index 498df0ce4680..20b49209ddcd 100644 > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > > @@ -1030,7 +1030,8 @@ static int vop2_plane_atomic_check(struct drm_plane *plane, > > return 0; > > > > format = vop2_convert_format(fb->format->format); > > - if (format < 0) > > + /* We shouldn't be able to create a fb for an unsupported format */ > > + if (WARN_ON(format < 0)) > > Please use drm_WARN_ON() here. Hi Thomas, A later revision of this series has already been applied. Feel free to send such a patch however. Kind regards, Nicolas Frattaroli > > Best regards > Thomas > > > return format; > > > > /* Co-ordinates have now been clipped */ > > > >