From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Darren Hart <dvhart@linux.intel.com>
Subject: Re: [PATCH 1/2 v2] WARN_ON_SMP(): Allow use in if statements on UP
Date: Fri, 18 Mar 2011 13:27:29 +0100 [thread overview]
Message-ID: <1300451249.21794.33.camel@twins> (raw)
In-Reply-To: <1300450473.16880.1476.camel@gandalf.stny.rr.com>
On Fri, 2011-03-18 at 08:14 -0400, Steven Rostedt wrote:
> On Fri, 2011-03-18 at 10:12 +0100, Peter Zijlstra wrote:
> > On Thu, 2011-03-17 at 17:56 -0400, Steven Rostedt wrote:
> > > + * WARN_ON(!spin_is_locked(&lock)) checks, as spin_is_locked()
> > > + * returns 0 for uniprocessor settings.
> >
> > Arguably most spin_is_locked() usages should be removed in favour of
> > something like lockdep_assert_held().
> >
> > The latter only emits code then built with lockdep enabled and it checks
> > we are indeed the owner, not some random other cpu.
> >
>
> Perhaps we should have lockdep_assert_held() also be in
> "spin_is_locked()".
Can't since its got stronger requirements.
next prev parent reply other threads:[~2011-03-18 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 21:56 [PATCH 0/2 v2] [GIT PULL] futex: Fix WARN_ON trigging on UP Steven Rostedt
2011-03-17 21:56 ` [PATCH 1/2 v2] WARN_ON_SMP(): Allow use in if statements " Steven Rostedt
2011-03-18 9:12 ` Peter Zijlstra
2011-03-18 12:14 ` Steven Rostedt
2011-03-18 12:27 ` Peter Zijlstra [this message]
2011-03-24 13:36 ` Steven Rostedt
2011-03-17 21:56 ` [PATCH 2/2 v2] futex: Fix WARN_ON() test for UP Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300451249.21794.33.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dvhart@linux.intel.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox