From: Ben Hutchings <bhutchings@solarflare.com>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: patch for format issues and header bug in net/ipv4/icmp.c
Date: Fri, 18 Mar 2011 19:41:01 +0000 [thread overview]
Message-ID: <1300477261.2589.28.camel@bwh-desktop> (raw)
In-Reply-To: <20110318183529.GA3617@debian.Jeff>
On Sat, 2011-03-19 at 00:05 +0530, Jeffrin Jose wrote:
> hello ,
>
> I have created a patch for net/ipv4/icmp.c
> using checkpatch.pl script to fix several warnings
> and an error.
You need to learn C programming before trying to correct C programs.
You should not just do what it takes to make checkpatch.pl happy.
Ben.
> I have attached the patch along with this mail.
>
> /Thanks
>
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-03-18 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 18:35 patch for format issues and header bug in net/ipv4/icmp.c Jeffrin Jose
2011-03-18 19:41 ` Ben Hutchings [this message]
2011-03-18 19:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300477261.2589.28.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=ahiliation@yahoo.co.in \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox