From: David Howells <dhowells@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: dhowells@redhat.com, James Morris <jmorris@namei.org>,
LKML <linux-kernel@vger.kernel.org>,
"Hannes Eder" <hannes@hanneseder.net>
Subject: Re: [PATCH] creds: suppress warning in get_cred
Date: Mon, 19 Jan 2009 20:19:00 +0000 [thread overview]
Message-ID: <13007.1232396340@redhat.com> (raw)
In-Reply-To: <20090120015251.47ea14ff.sfr@canb.auug.org.au>
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> We do have uintptr_t inside the kernel (it is typedeffed to unsigned
> long) but I used it explicitly because its type is defined to be large
> enough to store any pointer.
I believe that within the kernel, unsigned long is guaranteed to be the same
size as a pointer; so much code will break if this is not true.
> However, I have also verified that using a newer compiler (4.3.2 in my
> case) makes the warning go away as Hannes Eder pointed out when
> mentioning his earlier patch.
>
> So, your choice.
I don't mind you putting the cast in, but I'd prefer the cast to be via
unsigned long, and I think it should have a comment to indicate why the extra
cast is necessary.
David
prev parent reply other threads:[~2009-01-19 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 10:10 [PATCH] creds: suppress warning in get_cred Stephen Rothwell
2009-01-19 11:03 ` Hannes Eder
2009-01-19 14:37 ` Stephen Rothwell
2009-01-19 12:29 ` David Howells
2009-01-19 14:52 ` Stephen Rothwell
2009-01-19 14:59 ` Hannes Eder
2009-01-19 20:19 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13007.1232396340@redhat.com \
--to=dhowells@redhat.com \
--cc=hannes@hanneseder.net \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox