From: Peter Zijlstra <peterz@infradead.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
David Collins <collinsd@codeaurora.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>
Subject: Re: Deadlock scenario in regulator core
Date: Fri, 25 Mar 2011 11:59:16 +0100 [thread overview]
Message-ID: <1301050756.2250.190.camel@laptop> (raw)
In-Reply-To: <20110323104230.GA778@opensource.wolfsonmicro.com>
On Wed, 2011-03-23 at 10:42 +0000, Mark Brown wrote:
>
> That's helpful, though it doesn't really say anything about how one
> picks subclass?
With care ;-)
Its most useful for recursive use of the same lock class, typically we
only have 2 locks held and we can use the SINGLE_DEPTH_NESTING thing.
Some few sites use subclasses for larger things, some are ok, some are
dubious (ext4 comes to mind).
And like said in the other email, be careful with lockdep annotations,
you can actually annotate real deadlocks away.
next prev parent reply other threads:[~2011-03-25 10:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 22:02 Deadlock scenario in regulator core David Collins
2011-03-22 22:31 ` Mark Brown
2011-03-22 23:30 ` David Collins
2011-03-22 23:45 ` Mark Brown
2011-03-22 22:37 ` Steven Rostedt
2011-03-22 23:08 ` David Collins
2011-03-22 23:19 ` Steven Rostedt
2011-03-22 23:41 ` David Collins
2011-03-23 0:07 ` Steven Rostedt
2011-03-23 0:11 ` Mark Brown
2011-03-25 10:55 ` Peter Zijlstra
2011-03-23 0:01 ` Mark Brown
2011-03-23 0:38 ` Steven Rostedt
2011-03-23 10:42 ` Mark Brown
2011-03-25 10:59 ` Peter Zijlstra [this message]
2011-03-22 22:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301050756.2250.190.camel@laptop \
--to=peterz@infradead.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=collinsd@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox