From: Peter Tyser <ptyser@xes-inc.com>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: linux-kernel@vger.kernel.org,
"'Grant Likely'" <grant.likely@secretlab.ca>,
Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
Subject: RE: [PATCH] gpio: ml_ioh_gpio: Fix output value of ioh_gpio_direction_output()
Date: Fri, 25 Mar 2011 09:47:01 -0500 [thread overview]
Message-ID: <1301064421.24947.231.camel@petert> (raw)
In-Reply-To: <C734E3BF5C7F418896D57EBBD1C709C4@hacdom.okisemi.com>
Hi Tomoya,
On Fri, 2011-03-25 at 09:31 +0900, Tomoya MORINAGA wrote:
> Hi Peter,
>
> On Friday, March 25, 2011 8:17 AM, Peter Tyser wrote:
>
> > The ioh_gpio_direction_output() function was missing a write
> > to set the desired output value. The function would properly
> > set the GPIO direction, but not the output value. The value
> > would have to manually be set with a follow up call to ioh_gpio_set().
>
> > This is untested - just noticed it while working on an
> > unrelated change. An ack or tested-by from someone with real
> > hardware would be appreciated.
>
> Thank you for your indication.
> Your saying is right.
> However since your patch looks incorrect,
> after testing, I will post new patch by next week.
Out of curiosity, what looks incorrect about the patch? The code to set
the GPIO value is identical to the code in ioh_gpio_set(), which was the
old code path.
Best,
Peter
next prev parent reply other threads:[~2011-03-25 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 23:17 [PATCH] gpio: ml_ioh_gpio: Fix output value of ioh_gpio_direction_output() Peter Tyser
2011-03-25 0:31 ` Tomoya MORINAGA
2011-03-25 14:47 ` Peter Tyser [this message]
2011-03-28 0:56 ` Tomoya MORINAGA
2011-03-25 15:04 ` [PATCH] gpio: pch_gpio: Fix output value of pch_gpio_direction_output() Peter Tyser
2011-03-31 21:16 ` Grant Likely
2011-03-31 21:17 ` Grant Likely
2011-03-31 21:18 ` [PATCH] gpio: ml_ioh_gpio: Fix output value of ioh_gpio_direction_output() Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301064421.24947.231.camel@petert \
--to=ptyser@xes-inc.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=toshiharu-linux@dsn.okisemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox