From: Joe Perches <joe@perches.com>
To: Ralf Thielow <ralf.thielow@googlemail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
Date: Sat, 26 Mar 2011 11:51:26 -0700 [thread overview]
Message-ID: <1301165486.17567.7.camel@Joe-Laptop> (raw)
In-Reply-To: <1301156180-12192-2-git-send-email-ralf.thielow@googlemail.com>
On Sat, 2011-03-26 at 17:16 +0100, Ralf Thielow wrote:
> Includes missing KERN_ facility level to printk().
[]
> diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
[]
> @@ -97,7 +97,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
> WORD bl_len;
> BYTE buf[8];
>
> - printk("SM_SCSI_Read_Capacity\n");
> + printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
There should not be a comma between KERN_<level> and format.
Compile tested?
> + printk(KERN_DEBUG, "bl_len = %x\n", bl_len);
> + printk(KERN_DEBUG, "bl_num = %x\n", bl_num);
next prev parent reply other threads:[~2011-03-26 18:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 16:16 [PATCH 1/4] staging: keucr: smscsi: Fixed most checkpatch warnings and errors Ralf Thielow
2011-03-26 16:16 ` [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
2011-03-26 18:51 ` Joe Perches [this message]
2011-03-26 19:11 ` Ralf Thielow
2011-03-26 19:26 ` Joe Perches
2011-03-26 19:33 ` Ralf Thielow
2011-03-26 16:16 ` [PATCH 3/4] staging: keucr: smscsi: Removed commented declarations and statements Ralf Thielow
2011-03-26 16:16 ` [PATCH 4/4] staging: keucr: smscsi: Removed unreachable return statements Ralf Thielow
-- strict thread matches above, loose matches on Subject: below --
2011-03-26 19:21 [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
2011-04-20 20:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301165486.17567.7.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf.thielow@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox