From: Joe Perches <joe@perches.com>
To: Ralf Thielow <ralf.thielow@googlemail.com>
Cc: devel@driverdev.osuosl.org, gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk().
Date: Sat, 26 Mar 2011 12:26:51 -0700 [thread overview]
Message-ID: <1301167611.17567.12.camel@Joe-Laptop> (raw)
In-Reply-To: <AANLkTi=dOCmcJ9MA03gtsK5oc4N4FH2thuhMjmv7_T6z@mail.gmail.com>
On Sat, 2011-03-26 at 20:11 +0100, Ralf Thielow wrote:
> Of course, the whole staging directory with "make clean
> M=drivers/staging && make M=drivers/staging".
> You're right. The "printk" function accept these but it's wrong.
Then you didn't really compile test it.
I suggest you check your compilation commands.
For instance:
diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c
index 6211686..dd3cf95 100644
--- a/drivers/staging/keucr/smscsi.c
+++ b/drivers/staging/keucr/smscsi.c
@@ -98,7 +98,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb)
WORD bl_len;
BYTE buf[8];
- printk("SM_SCSI_Read_Capacity\n");
+ printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n");
bl_len = 0x200;
bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1;
$ make drivers/staging/keucr/smscsi.o
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CC drivers/staging/keucr/smscsi.o
drivers/staging/keucr/smscsi.c: In function ‘SM_SCSI_Read_Capacity’:
drivers/staging/keucr/smscsi.c:101:2: warning: too many arguments for format
next prev parent reply other threads:[~2011-03-26 19:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 16:16 [PATCH 1/4] staging: keucr: smscsi: Fixed most checkpatch warnings and errors Ralf Thielow
2011-03-26 16:16 ` [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
2011-03-26 18:51 ` Joe Perches
2011-03-26 19:11 ` Ralf Thielow
2011-03-26 19:26 ` Joe Perches [this message]
2011-03-26 19:33 ` Ralf Thielow
2011-03-26 16:16 ` [PATCH 3/4] staging: keucr: smscsi: Removed commented declarations and statements Ralf Thielow
2011-03-26 16:16 ` [PATCH 4/4] staging: keucr: smscsi: Removed unreachable return statements Ralf Thielow
-- strict thread matches above, loose matches on Subject: below --
2011-03-26 19:21 [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk() Ralf Thielow
2011-04-20 20:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301167611.17567.12.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf.thielow@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox