From: wni@nvidia.com
To: sameo@linux.intel.com, linux-kernel@vger.kernel.org
Cc: ccross@android.com, vwadekar@nvidia.com, Wei Ni <wni@nvidia.com>
Subject: [PATCH] mfd: call disable_irq()/enable_irq() in suspend/resume
Date: Tue, 29 Mar 2011 14:16:30 +0800 [thread overview]
Message-ID: <1301379390-28063-1-git-send-email-wni@nvidia.com> (raw)
From: Wei Ni <wni@nvidia.com>
When use rtc tps6586x wakealarm to suspend/resume system,
it will show a lot error messages:
"tps6586x 4-0034: failed to read interrupt status
tps6586x 4-0034: failed reading from 0xb5"
After resume, the system will call the mfd tps6586x driver's interrupt handle
tps6586x_irq(). This handle will read tps6586x interrupt status (0xb5), but at
that time the i2c driver didn't resume yet, so the reading will be failed.
I call the disble_irq in the suspend, and enable_irq in the resume, which will
delay the delivery of the irq until the i2c driver has been resumed.
Signed-off-by: Wei Ni <wni@nvidia.com>
---
drivers/mfd/tps6586x.c | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
index b600808..c7bd96b 100644
--- a/drivers/mfd/tps6586x.c
+++ b/drivers/mfd/tps6586x.c
@@ -569,6 +569,22 @@ static const struct i2c_device_id tps6586x_id_table[] = {
};
MODULE_DEVICE_TABLE(i2c, tps6586x_id_table);
+#ifdef CONFIG_PM
+static int tps6586x_suspend(struct i2c_client *client, pm_message_t mesg)
+{
+ if (client->irq)
+ disable_irq(client->irq);
+ return 0;
+}
+
+static int tps6586x_resume(struct i2c_client *client)
+{
+ if (client->irq)
+ enable_irq(client->irq);
+ return 0;
+}
+#endif
+
static struct i2c_driver tps6586x_driver = {
.driver = {
.name = "tps6586x",
@@ -577,6 +593,10 @@ static struct i2c_driver tps6586x_driver = {
.probe = tps6586x_i2c_probe,
.remove = __devexit_p(tps6586x_i2c_remove),
.id_table = tps6586x_id_table,
+#ifdef CONFIG_PM
+ .suspend = tps6586x_suspend,
+ .resume = tps6586x_resume,
+#endif
};
static int __init tps6586x_init(void)
--
1.7.0
next reply other threads:[~2011-03-29 6:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 6:16 wni [this message]
2011-03-30 6:19 ` [PATCH] mfd: call disable_irq()/enable_irq() in suspend/resume Wei Ni
2011-04-18 9:57 ` Wei Ni
2011-05-02 13:16 ` Samuel Ortiz
2011-05-04 6:49 ` Wei Ni
2011-05-10 8:23 ` Wei Ni
-- strict thread matches above, loose matches on Subject: below --
2011-03-29 5:51 wni
2011-03-29 5:58 ` Varun Wadekar
2011-03-29 6:04 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301379390-28063-1-git-send-email-wni@nvidia.com \
--to=wni@nvidia.com \
--cc=ccross@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=vwadekar@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox