From: Joe Perches <joe@perches.com>
To: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
Cc: Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/23] fujitsu-laptop: Convert printks to pr_<level>
Date: Tue, 29 Mar 2011 15:50:13 -0700 [thread overview]
Message-ID: <1301439013.4113.12.camel@Joe-Laptop> (raw)
In-Reply-To: <201103292242.p2TMgAET020124@turbo.physics.adelaide.edu.au>
On Wed, 2011-03-30 at 08:12 +0930, Jonathan Woithe wrote:
> what does pr_*() give us over printk()?
Consistency in use of prefix.
> I presume it makes it easier to selectively remove certain
> printk levels from the kernel image in the
> name of size reduction.
That's the goal, but there's no support in the
standard kernel for that yet.
It should also in the future make the prefix a
singleton and remove it from the format string
making the image text a bit smaller.
> Some people *may* insist that these long (>80 character) pr_err() lines be
> split so they remain <80 in length. This was the reason why the original
> printk() call was split like it was.
I don't.
It makes grepping source for strings easier.
cheers, Joe
next prev parent reply other threads:[~2011-03-29 22:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 22:21 [PATCH 00/23] drivers/platform/x86: Remove warnings and use pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 01/23] asus-wmi: Remove __init from asus_wmi_platform_init Joe Perches
2011-03-31 7:17 ` Corentin Chary
2011-03-29 22:21 ` [PATCH 02/23] ibm_rtl: Remove warnings from casts of pointer to int Joe Perches
2011-03-29 22:21 ` [PATCH 03/23] acer-wmi: pr_<level> cleanups Joe Perches
2011-03-31 6:41 ` Joey Lee
2011-03-29 22:21 ` [PATCH 04/23] asus: Add pr_fmt and convert printks to pr_<level> Joe Perches
2011-03-31 7:18 ` Corentin Chary
2011-03-29 22:21 ` [PATCH 05/23] compal-laptop: Convert " Joe Perches
2011-03-29 22:21 ` [PATCH 06/23] dell: " Joe Perches
2011-03-29 22:21 ` [PATCH 07/23] eeepc: Use pr_warn Joe Perches
2011-03-31 7:19 ` Corentin Chary
2011-03-29 22:21 ` [PATCH 08/23] fujitsu-laptop: Convert printks to pr_<level> Joe Perches
2011-03-29 22:42 ` Jonathan Woithe
2011-03-29 22:50 ` Joe Perches [this message]
2011-03-29 22:21 ` [PATCH 09/23] hdaps: " Joe Perches
2011-03-30 1:54 ` Lucas De Marchi
2011-03-30 2:00 ` Joe Perches
2011-03-29 22:21 ` [PATCH 10/23] hp-wmi: " Joe Perches
2011-03-29 22:21 ` [PATCH 11/23] ibm_rtl: Use pr_fmt and pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 12/23] ideapad-laptop: Add pr_fmt Joe Perches
2011-03-29 22:21 ` [PATCH 13/23] intel_menlow: Add pr_fmt and use pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 14/23] intel_pmic_gpio: Convert printks to pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 15/23] msi-laptop: pr_<level> neatening Joe Perches
2011-03-31 6:41 ` Joey Lee
2011-03-29 22:21 ` [PATCH 16/23] msi-wmi: Use pr_fmt and pr_<level> Joe Perches
2011-03-30 14:16 ` Anisse Astier
2011-03-29 22:21 ` [PATCH 17/23] sony-laptop: Add and use #define pr_fmt Joe Perches
2011-03-29 22:21 ` [PATCH 18/23] tc1100-wmi: Add pr_fmt, use pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 19/23] thinkpad_acpi: Convert printks to pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 20/23] topstar-laptop: Convert remaining printk to pr_info Joe Perches
2011-03-29 23:44 ` Herton Ronaldo Krzesinski
2011-03-29 22:21 ` [PATCH 21/23] toshiba: Convert printks to pr_<level> Joe Perches
2011-03-29 22:21 ` [PATCH 22/23] wmi: Removed trailing whitespace from logging message Joe Perches
2011-03-29 22:21 ` [PATCH 23/23] xo15-ebook: Use pr_<level> Joe Perches
2011-03-30 14:30 ` [PATCH 00/23] drivers/platform/x86: Remove warnings and use pr_<level> Corentin Chary
2011-03-30 15:02 ` Joe Perches
2011-04-01 18:21 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301439013.4113.12.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox