From: Artem Bityutskiy <dedekind1@gmail.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: MTD list <linux-mtd@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] UBIFS: do not select KALLSYMS_ALL
Date: Wed, 30 Mar 2011 11:40:15 +0300 [thread overview]
Message-ID: <1301474416-8202-2-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1301474416-8202-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
All UBIFS needs is to make sure we stacktraces when UBIFS debugging
is enabled. It is enough to select KALLSYMS for this, KALLSYMS_ALL
is not necessary. Moreover, Randy Dunlap reported that UBIFS causes
the following Kconfig dependency warning:
warning: (UBIFS_FS_DEBUG && LOCKDEP && LATENCYTOP) selects KALLSYMS_ALL
which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
The reason is that KALLSYMS_ALL requires DEBUG_KERNEL and KALLSYMS, so
ideally, to select KALLSYMS_ALL we'd need to select DEBUG_KERNEL and
KALLSYMS first.
This seems to be too much to select. The easiest way to go is to forget
about KALLSYMS_ALL and just select KALLSYMS when UBIFS debugging is
enabled - that should be enough for stackdumps.
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
fs/ubifs/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
index d744090..f8b0160 100644
--- a/fs/ubifs/Kconfig
+++ b/fs/ubifs/Kconfig
@@ -47,7 +47,7 @@ config UBIFS_FS_DEBUG
bool "Enable debugging support"
depends on UBIFS_FS
select DEBUG_FS
- select KALLSYMS_ALL
+ select KALLSYMS
help
This option enables UBIFS debugging support. It makes sure various
assertions, self-checks, debugging messages and test modes are compiled
--
1.7.2.3
next prev parent reply other threads:[~2011-03-30 8:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 8:40 [PATCH 0/2] do not select KALLSYMS_ALL Artem Bityutskiy
2011-03-30 8:40 ` Artem Bityutskiy [this message]
2011-03-30 22:41 ` [PATCH 1/2] UBIFS: " Randy Dunlap
2011-03-31 6:29 ` Artem Bityutskiy
2011-03-30 8:40 ` [PATCH 2/2] UBI: " Artem Bityutskiy
2011-03-30 22:41 ` Randy Dunlap
2011-03-31 14:18 ` [PATCH 0/2] " Paulo Marques
2011-04-01 14:40 ` Artem Bityutskiy
2011-04-01 14:56 ` Artem Bityutskiy
2011-04-01 15:01 ` Artem Bityutskiy
2011-04-01 15:11 ` Ricard Wanderlof
2011-04-01 15:34 ` Paulo Marques
2011-04-01 15:42 ` Artem Bityutskiy
2011-04-01 15:54 ` Paulo Marques
2011-04-04 7:12 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301474416-8202-2-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox