Re: [Sony Vaio TX3] TPM chip prevents machine from suspending a second time

Stefan Berger
2012-01-23T20:54:20Z

On 01/21/2012 12:01 PM, Jonathan Nieder wrote:
> Hi Stefan et al,
>
> John Hughes wrote[1]:
>
>> On a sony vaio tx3 when tpm_tis is loaded suspend only works once.
>
>> Well, we now could (once) probe the TPM after the resume and send a test
>> command to it and see whether it returns error code 38 and if so send
>> the TPM_Startup() from the driver -- as a work-around for your broken BIOS.
> Versions tested and found to exhibit the problem:
>
> - Debian 2.6.35~rc6-1~experimental.1 (close to v2.6.35-rc6)
> - Debian 2.6.36-1~experimental.1 (close to v2.6.36)
> - Debian 2.6.37~rc5-1~experimental.3 (close to v2.6.37-rc5)
> - Debian 2.6.37-1 (close to v2.6.37)
> - v3.2-rc2 + Vaio keyboard fixes
> - Debian 3.2.1-1 (close to v3.2.1)
> - v3.3-rc1 + Vaio keyboard fixes
>
> Known problem? Any hints for getting this to work out of the box? (If
> there's no generic fix, maybe it would be possible to use a quirks
> table of some kind?)

Can you apply the patch below to your tpm_tis.c (or somewhere else in
the kernel) and let me/us know what it reports in 'dmesg' upon a
'modprobe tpm_tis'? You can cut out serial numbers and UUIDs if you
want. I am also not sure whether it's a good idea to use DMI information
for quirks in general, but the idea would be to have a table of systems
with known problems, identify them using their SMBIOS information and
only apply the work-arounds to them. As stated previously what needs to
be sent upon resume is a TPM_Startup(ST_STATE). Even though it shouldn't
hurt to send this command two times to the TPM in general (from BIOS and
Linux) even on working machines I don't want to find out about side
effects ... for sure that would be much easier and much less code...

Stefan

---
drivers/char/tpm/tpm_tis.c | 5 +++++
1 file changed, 5 insertions(+)

Index: linux-2.6/drivers/char/tpm/tpm_tis.c
===================================================================
--- linux-2.6.orig/drivers/char/tpm/tpm_tis.c
+++ linux-2.6/drivers/char/tpm/tpm_tis.c
@@ -27,6 +27,7 @@
#include <linux/wait.h>
#include <linux/acpi.h>
#include <linux/freezer.h>
+#include <linux/dmi.h>
#include "tpm.h"

enum tis_access {
@@ -535,6 +536,10 @@ static int tpm_tis_init(struct device *d

vendor = ioread32(chip->vendor.iobase + TPM_DID_VID(0));

+ for (i = 0; i < DMI_STRING_MAX; i++)
+ dev_info(dev, "dmi: %d: %s\n",
+ i, dmi_get_system_info(i));
+
dev_info(dev,
"1.2 TPM (device-id 0x%X, rev-id %d)\n",
vendor >> 16, ioread8(chip->vendor.iobase + TPM_RID(0)));