public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Oleg Nesterov <oleg@redhat.com>
Subject: perf and cgroup event scheduling
Date: Thu, 31 Mar 2011 15:27:07 +0200	[thread overview]
Message-ID: <1301578027.4859.256.camel@twins> (raw)

Hi Stephane,

while trying to make sense of various other fun event scheduling issues,
I noticed that perf_cgroup_switch() isn't always doing the right thing.

So we typically want to schedule: CPU-pinned, TASK-pinned, CPU-flexible
TASK-flexible, however the current code doesn't respect that.

In particular perf_cgroup_sched_in() is placed wrong, it should be
_before_ we schedule in the task contexts.

There's further complications with things like perf_install_in_context()
and perf_cgroup_move(), but those are either rare or 'interesting' to
fix.



             reply	other threads:[~2011-03-31 13:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31 13:27 Peter Zijlstra [this message]
2011-03-31 17:06 ` perf and cgroup event scheduling Stephane Eranian
2011-03-31 17:12   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301578027.4859.256.camel@twins \
    --to=peterz@infradead.org \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox