public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"2nddept-manager@sdl.hitachi.co.jp" 
	<2nddept-manager@sdl.hitachi.co.jp>
Subject: Re: [RFC PATCH] perf report: add sort by file lines
Date: Thu, 31 Mar 2011 16:01:57 +0200	[thread overview]
Message-ID: <1301580117.4859.286.camel@twins> (raw)
In-Reply-To: <1301561155.14111.288.camel@minggr.sh.intel.com>

On Thu, 2011-03-31 at 16:45 +0800, Lin Ming wrote:
> I am considering if it is possible to do "instruction unwind" to get a
> map from (temporarily used) register to a specific member of a data
> structure pointed by a pointer.
> 
> 4004a0:         movq    -8(%rbp), %rax    /* load foo arg from stack
> */
> 4004a4:         movq    24(%rax), %rax    /* load foo->bar */
> 4004a8:         movq    -16(%rbp), %rdx   /* load tmp arg from stack
> */
> 4004ac:         movl    32(%rdx), %edx    /* load tmp->blah */
> 4004af:         movl    %edx, 20(%rax)    /* store bar->fubar */ 
> 
> foo: -8(%rbp)
> tmp: -16(%rbp)
> 
> Assume we are now at ip 4004af, from the instruction decoder, we know
> it's a store operation, and we want to find out what %rax is.
> 
> 1. unwind to 4004ac
>    Ignore this, because it does not touch %rax
> 
> 2. unwind to 4004a8
>    Ignore this, because it does not touch %rax
> 
> 3. unwind to 4004a4
>    20(%rax) => 20(24(%rax)), continue to unwind because we still
>    have no idea what %rax is
> 
> 4. unwind to 4004a0
>    20(24(%rax)) => 20(24(-8(%rbp))), stop unwind, because we now know
>    -8(%rbp) is foo.
> 
> So the original 20(%rax) is replace as 20(24(-8(%rbp))), and it means
> foo->bar->fubar
> 
> Does this make sense? 

Yes and no, the problem is that you cannot unwind an x86 instruction
stream. Therefore its easier to start at the beginning of a function
where DWARF should be able to tell you everything you need and then do a
single fwd scan to propagate the information until you reach the point
of interest.

  parent reply	other threads:[~2011-03-31 14:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29  9:32 [RFC PATCH] perf report: add sort by file lines Lin Ming
2011-03-29  9:46 ` Masami Hiramatsu
2011-03-29  9:54 ` Peter Zijlstra
2011-03-29 16:45   ` Lin Ming
2011-03-29 17:03     ` Peter Zijlstra
2011-03-29 17:06       ` Peter Zijlstra
2011-03-29 17:08         ` Peter Zijlstra
2011-03-29 17:45           ` Arnaldo Carvalho de Melo
2011-03-30  1:04             ` Masami Hiramatsu
2011-03-30  2:18               ` Arnaldo Carvalho de Melo
2011-03-31  6:57               ` Lin Ming
2011-04-01 10:48                 ` Masami Hiramatsu
2011-03-31  8:45               ` Lin Ming
2011-03-31 13:46                 ` Arnaldo Carvalho de Melo
2011-03-31 14:19                   ` Lin Ming
2011-03-31 15:35                     ` Arnaldo Carvalho de Melo
2011-03-31 14:01                 ` Peter Zijlstra [this message]
2011-03-31 14:34                   ` Lin Ming
2011-03-31 14:51                     ` Lin Ming
2011-03-31 16:28                     ` Peter Zijlstra
2011-03-31 16:32                       ` Peter Zijlstra
2011-04-01 13:02                         ` Lin Ming
2011-04-01 13:48                           ` Peter Zijlstra
2011-04-01 10:44                       ` Masami Hiramatsu
2011-04-01 11:05                         ` Peter Zijlstra
2011-04-01 13:22                           ` Lin Ming
2011-04-01 13:49                             ` Peter Zijlstra
2011-04-01 13:57                               ` Lin Ming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301580117.4859.286.camel@twins \
    --to=peterz@infradead.org \
    --cc=2nddept-manager@sdl.hitachi.co.jp \
    --cc=acme@infradead.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=ming.m.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox