From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: perf and cgroup event scheduling
Date: Thu, 31 Mar 2011 19:12:22 +0200 [thread overview]
Message-ID: <1301591542.2250.500.camel@laptop> (raw)
In-Reply-To: <BANLkTinmnSqMqtLsfE8ktXmbnGdp1COW0A@mail.gmail.com>
On Thu, 2011-03-31 at 10:06 -0700, Stephane Eranian wrote:
> Peter,
>
> On Thu, Mar 31, 2011 at 6:27 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> > Hi Stephane,
> >
> > while trying to make sense of various other fun event scheduling issues,
> > I noticed that perf_cgroup_switch() isn't always doing the right thing.
> >
> > So we typically want to schedule: CPU-pinned, TASK-pinned, CPU-flexible
> > TASK-flexible, however the current code doesn't respect that.
> >
> Unfortunately, you are right ;-). I think we should try to centralize
> the scheduling
> of per-cpu and per-thread event in a single function that goes through
> the priority
> list. In certain cases, we would sched out and back in per-thread
> events, but that
> would be the only to maintain the priority scheme. I will look into that.
I've done something near to that here:
https://lkml.org/lkml/2011/3/31/232
but that patch is very fresh and not tested at all.
>
> In the meantime, yesterday, I found and fixed one potential kernel crash problem
> related to mixing cgroup + per-thread events. I will be posting the
> patch shortly.
Looking fwd to that, Thanks!
prev parent reply other threads:[~2011-03-31 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 13:27 perf and cgroup event scheduling Peter Zijlstra
2011-03-31 17:06 ` Stephane Eranian
2011-03-31 17:12 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301591542.2250.500.camel@laptop \
--to=peterz@infradead.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox