From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Lin Ming <ming.m.lin@intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [RFC] [PATCH] perf, x86: Add PERF_COUNT_HW_NMI_WATCHDOG event
Date: Fri, 01 Apr 2011 12:53:14 +0200 [thread overview]
Message-ID: <1301655194.4859.479.camel@twins> (raw)
In-Reply-To: <4D94EF4B.6070905@gmail.com>
On Fri, 2011-04-01 at 01:16 +0400, Cyrill Gorcunov wrote:
> Because of Netburst HW restriction we can't move events arbitrary
> between counters and this makes 'perf top' unable to run if nmi-watchdog
> is running (since both uses PERF_COUNT_HW_CPU_CYCLES but such event is
> bound to run on a few counters only). So as a workaround we could count that named
> non-sleeping ticks (as oprofile does) and both perf top and nmi-watchdog would co-exsist
> without conflicts but kernel needs to know about such specifics -- so PERF_COUNT_HW_NMI_WATCHDOG
> event is introduced. This event is an alias of PERF_COUNT_HW_CPU_CYCLES for non-P4 x86
> architecture so nothing much changed I think.
>
> Please review, I might be missing something. Also comments on idea is quite welcome since
> it touches ABI part.
> arch/x86/kernel/cpu/perf_event_amd.c | 1 +
> arch/x86/kernel/cpu/perf_event_intel.c | 1 +
> arch/x86/kernel/cpu/perf_event_p4.c | 15 +++++++++++++++
> arch/x86/kernel/cpu/perf_event_p6.c | 1 +
> include/linux/perf_event.h | 1 +
> kernel/watchdog.c | 2 +-
> 6 files changed, 20 insertions(+), 1 deletions(-)
is x86 the only arch using the watchdog things?
next prev parent reply other threads:[~2011-04-01 10:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 21:16 [RFC] [PATCH] perf, x86: Add PERF_COUNT_HW_NMI_WATCHDOG event Cyrill Gorcunov
2011-04-01 10:53 ` Peter Zijlstra [this message]
2011-04-01 11:05 ` Cyrill Gorcunov
2011-04-01 11:33 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301655194.4859.479.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox