From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754871Ab1DDPNg (ORCPT ); Mon, 4 Apr 2011 11:13:36 -0400 Received: from mail.perches.com ([173.55.12.10]:4464 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754696Ab1DDPNe (ORCPT ); Mon, 4 Apr 2011 11:13:34 -0400 Subject: Re: linux-next: Tree for April 4 [BROKEN thinkpad_acpi] From: Joe Perches To: sedat.dilek@gmail.com Cc: Matthew Garrett , Stephen Rothwell , linux-next@vger.kernel.org, LKML , platform-driver-x86 , ibm-acpi@hmh.eng.br In-Reply-To: References: <20110404122225.GA15883@srcf.ucam.org> <1301921369.1941.29.camel@Joe-Laptop> <20110404130036.GB16669@srcf.ucam.org> <1301929346.1941.32.camel@Joe-Laptop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 04 Apr 2011 08:13:32 -0700 Message-ID: <1301930012.1941.36.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-04-04 at 17:08 +0200, Sedat Dilek wrote: > On Mon, Apr 4, 2011 at 5:02 PM, Joe Perches wrote: > > On Mon, 2011-04-04 at 16:44 +0200, Sedat Dilek wrote: > >> > I have tried with solution #2 as it partially restores old behaviour > >> > (patch is attached). > > Partially? Please explain. > -#define vdbg_printk(a_dbg_level, format, arg...) \ > - do { } while (0) > +#define vdbg_printk(a_dbg_level, format, arg...) \ > + no_printk(format, ##arg) I understand the reversed patch. My point was focused on the word "partially".