From: Artem Bityutskiy <dedekind1@gmail.com>
To: Valdis.Kletnieks@vt.edu
Cc: Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Paulo Marques <pmarques@grupopie.com>
Subject: Re: [PATCH 2/2] kbuild: move KALLSYMS_EXTRA_PASS from Kconfig to Makefile
Date: Mon, 04 Apr 2011 18:37:44 +0300 [thread overview]
Message-ID: <1301931464.2760.101.camel@localhost> (raw)
In-Reply-To: <7621.1301930536@localhost>
On Mon, 2011-04-04 at 11:22 -0400, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 04 Apr 2011 15:47:10 +0300, Artem Bityutskiy said:
> > On Mon, 2011-04-04 at 08:45 -0400, Valdis.Kletnieks@vt.edu wrote:
> > > On Mon, 04 Apr 2011 13:40:51 +0300, Artem Bityutskiy said:
> > >
> > > > 3. By default KALLSYMS_EXTRA_PASS is disabled and if kallsyms has issues,
> > > > "make" should print a warning and suggest using KALLSYMS_EXTRA_PASS
> > >
> > > If the Makefile has enough information to print the warning, why can't it go
> > > ahead and do the extra pass itself instead of issuing the warning?
> > >
> > > (I'm obviously missing something here, as I'm foolishly posting to lkml before
> > > caffeine ;)
> >
> > Good question, I thought to force people to send a bugreport.
>
> When was the last time we actually saw such a bug report? I'm suspecting that
> all the affected people just set the variable and get on with their lives. So
> we should either just make it automatic if that's what people are going to do,
> or we rip the entire "EXTRA_PASS' stuff out forcibly and *make* people fix the
> actual underlying issue that causes the extra pass to be needed...
I do not know when this bug was last seen, but I'd not remove this
"extra pass" work around so far. WRT automatic fix-up - I do not have
strong opinion here, but Paulo Marques pointed in another thread that
due to various alignment issues the bug is tricky and may come back. So
probably removing working code is not very wise. Thus, it seems the way
I proposed in this patch is a good balance.
But anyway, if Michal Marek requests to change this, I'll do this (he is
the Maintainer).
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-04-04 15:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 10:40 [PATCH 1/2] Kconfig: improve KALLSYMS_ALL documentation Artem Bityutskiy
2011-04-04 10:40 ` [PATCH 2/2] kbuild: move KALLSYMS_EXTRA_PASS from Kconfig to Makefile Artem Bityutskiy
2011-04-04 12:17 ` Michal Marek
2011-04-04 12:48 ` Artem Bityutskiy
2011-04-04 12:45 ` Valdis.Kletnieks
2011-04-04 12:47 ` Artem Bityutskiy
2011-04-04 15:22 ` Valdis.Kletnieks
2011-04-04 15:37 ` Artem Bityutskiy [this message]
2011-04-04 16:01 ` Paulo Marques
2011-04-04 15:47 ` Artem Bityutskiy
2011-04-04 16:22 ` [PATCH 1/2] Kconfig: improve KALLSYMS_ALL documentation Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301931464.2760.101.camel@localhost \
--to=dedekind1@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pmarques@grupopie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox