From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753978Ab1DENbg (ORCPT ); Tue, 5 Apr 2011 09:31:36 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:48251 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752494Ab1DEN2T convert rfc822-to-8bit (ORCPT ); Tue, 5 Apr 2011 09:28:19 -0400 Subject: Re: [patch 10/15] sched: (fixlet) dont update shares twice on on_rq parent From: Peter Zijlstra To: Paul Turner Cc: linux-kernel@vger.kernel.org, Bharata B Rao , Dhaval Giani , Balbir Singh , Vaidyanathan Srinivasan , Srivatsa Vaddagiri , Kamalesh Babulal , Ingo Molnar , Pavel Emelyanov In-Reply-To: <20110323030449.628616053@google.com> References: <20110323030326.789836913@google.com> <20110323030449.628616053@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Tue, 05 Apr 2011 15:28:11 +0200 Message-ID: <1302010091.2225.1315.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-03-22 at 20:03 -0700, Paul Turner wrote: > In dequeue_task_fair() we bail on dequeue when we encounter a parenting entity > with additional weight. However, we perform a double shares update on this > entity since we continue the shares update traversal from that point, despite > dequeue_entity() having already updated its queuing cfs_rq. > > Avoid this by starting from the parent when we resume. I'm thinking this fixlet is orthogonal to the rest of this patch-set and should go in now? (Usually such things live at the head of a series)