public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/mrst: correct pin to irq mapping
@ 2011-04-07 18:32 Jacob Pan
  2011-04-08 15:45 ` Ingo Molnar
  0 siblings, 1 reply; 3+ messages in thread
From: Jacob Pan @ 2011-04-07 18:32 UTC (permalink / raw)
  To: H. Peter Anvin, Ingo Molnar, Eric W. Biederman, LKML, Feng Tang,
	Alan Cox, Arjan van de Ven
  Cc: Jacob Pan

Set mp_bus_not_pci bit to allow 1:1 mapping of pin2irq on Moorestown.
Refer to discussion in:
https://lkml.org/lkml/2010/6/10/70

Suggested-by: "Eric W. Biederman" <ebiederm@xmission.com>

Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
 arch/x86/platform/mrst/mrst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
index 5c0207b..d51d644 100644
--- a/arch/x86/platform/mrst/mrst.c
+++ b/arch/x86/platform/mrst/mrst.c
@@ -282,7 +282,7 @@ void __init x86_mrst_early_setup(void)
 	/* Avoid searching for BIOS MP tables */
 	x86_init.mpparse.find_smp_config = x86_init_noop;
 	x86_init.mpparse.get_smp_config = x86_init_uint_noop;
-
+	set_bit(0, mp_bus_not_pci);
 }
 
 /*
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86/mrst: correct pin to irq mapping
  2011-04-07 18:32 [PATCH] x86/mrst: correct pin to irq mapping Jacob Pan
@ 2011-04-08 15:45 ` Ingo Molnar
  2011-04-08 18:24   ` jacob pan
  0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2011-04-08 15:45 UTC (permalink / raw)
  To: Jacob Pan
  Cc: H. Peter Anvin, Eric W. Biederman, LKML, Feng Tang, Alan Cox,
	Arjan van de Ven


* Jacob Pan <jacob.jun.pan@linux.intel.com> wrote:

> Set mp_bus_not_pci bit to allow 1:1 mapping of pin2irq on Moorestown.
> Refer to discussion in:
> https://lkml.org/lkml/2010/6/10/70
> 
> Suggested-by: "Eric W. Biederman" <ebiederm@xmission.com>
> 
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
>  arch/x86/platform/mrst/mrst.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Could you please improve the changelog to explain to the reader:

 - why has this change been done
 - what are the effects on users (if any)
 - what is the urgency of the patch (needed for .39, or can wait for .40)

lkml.org links may or may not work in the future, we really need proper 
background information in changelogs.

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86/mrst: correct pin to irq mapping
  2011-04-08 15:45 ` Ingo Molnar
@ 2011-04-08 18:24   ` jacob pan
  0 siblings, 0 replies; 3+ messages in thread
From: jacob pan @ 2011-04-08 18:24 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: H. Peter Anvin, Eric W. Biederman, LKML, Feng Tang, Alan Cox,
	Arjan van de Ven


> Could you please improve the changelog to explain to the reader:
Yes, I just sent out an updated version 2 with documentation and little
more clean ups.

Thanks for pointing it out.

Jacob

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-04-08 18:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-07 18:32 [PATCH] x86/mrst: correct pin to irq mapping Jacob Pan
2011-04-08 15:45 ` Ingo Molnar
2011-04-08 18:24   ` jacob pan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox