From: Ben Hutchings <ben@decadent.org.uk>
To: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] avr32: Fix .size directive for cpu_enter_idle
Date: Fri, 08 Apr 2011 00:48:19 +0100 [thread overview]
Message-ID: <1302220099.5282.11.camel@localhost> (raw)
In-Reply-To: <1299630756.4146.25.camel@localhost>
[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]
On Wed, 2011-03-09 at 00:32 +0000, Ben Hutchings wrote:
> gas used to accept (and ignore?) .size directives which referred to
> undefined symbols, as this does. In binutils 2.21 these are treated
> as errors.
Please acknowledge and send this upstream.
Ben.
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> arch/avr32/mach-at32ap/pm-at32ap700x.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/avr32/mach-at32ap/pm-at32ap700x.S b/arch/avr32/mach-at32ap/pm-at32ap700x.S
> index 17503b0..f868f4c 100644
> --- a/arch/avr32/mach-at32ap/pm-at32ap700x.S
> +++ b/arch/avr32/mach-at32ap/pm-at32ap700x.S
> @@ -53,7 +53,7 @@ cpu_enter_idle:
> st.w r8[TI_flags], r9
> unmask_interrupts
> sleep CPU_SLEEP_IDLE
> - .size cpu_idle_sleep, . - cpu_idle_sleep
> + .size cpu_enter_idle, . - cpu_enter_idle
>
> /*
> * Common return path for PM functions that don't run from
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2011-04-07 23:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 0:21 [PATCH 0/5] Fix build failures with binutils 2.21 Ben Hutchings
2011-03-09 0:29 ` [PATCH 1/5] x86: Fix .size directive for xen_do_hypervisor_callback Ben Hutchings
2011-03-09 0:31 ` [PATCH 2/5] x86: Fix .size directive for async_page_fault Ben Hutchings
2011-03-09 0:32 ` [PATCH 4/5] avr32: Fix .size directive for cpu_enter_idle Ben Hutchings
2011-03-09 4:28 ` Hans-Christian Egtvedt
2011-04-07 23:48 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302220099.5282.11.camel@localhost \
--to=ben@decadent.org.uk \
--cc=hans-christian.egtvedt@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox