From: Mike Galbraith <efault@gmx.de>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"Yan, Zheng Z" <zheng.z.yan@intel.com>
Subject: Re: [PATCH]sched: convert wall-time to vruntime for check_preempt_tick
Date: Fri, 08 Apr 2011 04:49:19 +0200 [thread overview]
Message-ID: <1302230959.7551.14.camel@marge.simson.net> (raw)
In-Reply-To: <1302222953.3981.88.camel@sli10-conroe>
On Fri, 2011-04-08 at 08:35 +0800, Shaohua Li wrote:
> On Thu, 2011-04-07 at 21:34 +0800, Mike Galbraith wrote:
> > On Thu, 2011-04-07 at 20:43 +0800, Shaohua Li wrote:
> > > In check_preempt_tick(), delta is vruntime and ideal_runtime is wall runtime.
> > > Comparing vruntime and ideal_runtime looks buggy.
> >
> > Why is that buggy? It's a distance in units ns, ala wakeup_granularity,
> > a number. This number just happens to be variable.
> vruntime is scaled wall-time. In all other places we do the scale from
> my understanding. I'm wondering why not do it here.
The purpose was to ensure that there is not too much spread, just like
wakeup preemption. Using the number that determines tick induced spread
as the spread caliper seems perfectly fine to me.
-Mike
next prev parent reply other threads:[~2011-04-08 2:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 12:43 [PATCH]sched: convert wall-time to vruntime for check_preempt_tick Shaohua Li
2011-04-07 13:34 ` Mike Galbraith
2011-04-08 0:35 ` Shaohua Li
2011-04-08 2:49 ` Mike Galbraith [this message]
2011-04-08 4:55 ` Shaohua Li
2011-04-08 5:31 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302230959.7551.14.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shaohua.li@intel.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox