From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jiri Pinkava <jiri.pinkava@vscht.cz>
Cc: ben-linux@fluff.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] nand: Fix S3C NAND clock stop
Date: Wed, 13 Apr 2011 06:36:24 +0300 [thread overview]
Message-ID: <1302665784.14691.5.camel@koala> (raw)
In-Reply-To: <1302533304-6795-1-git-send-email-jiri.pinkava@vscht.cz>
On Mon, 2011-04-11 at 16:48 +0200, Jiri Pinkava wrote:
> Current implementation of s3c2410_nand_select_chip call
> clk_disable every time when chip = -1 (de-select). This happend
> multiple times even if chip was already de-selected. This causes
> disabling clock even if they are already disabled and due to
> nature of clock subsytem implementation this causes nand clock
> to be disabled and newer enabled again.
>
> Signed-off-by: Jiri Pinkava <jiri.pinkava@vscht.cz>
> ---
> drivers/mtd/nand/s3c2410.c | 59 ++++++++++++++++++++++++++++++++------------
> 1 files changed, 43 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
> index 33d832d..cea775a 100644
> --- a/drivers/mtd/nand/s3c2410.c
> +++ b/drivers/mtd/nand/s3c2410.c
> @@ -55,7 +55,7 @@ static int hardware_ecc = 0;
> #endif
>
> #ifdef CONFIG_MTD_NAND_S3C2410_CLKSTOP
> -static int clock_stop = 1;
> +static const int clock_stop = 1;
> #else
> static const int clock_stop = 0;
> #endif
Please, kill clock_stop variable completely in a separate patch.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2011-04-13 3:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 1:27 [PATCH] nand: Fix S3C NAND clock stop Jiri Pinkava
2011-04-11 2:05 ` Randy Dunlap
2011-04-11 3:15 ` Jiří Pinkava
2011-04-11 14:48 ` Jiri Pinkava
2011-04-13 3:36 ` Artem Bityutskiy [this message]
2011-04-13 9:59 ` [PATCH 1/2] " Jiri Pinkava
2011-04-13 9:59 ` [PATCH 2/2] nand: Remove unnecessary variable Jiri Pinkava
2011-04-14 12:17 ` Artem Bityutskiy
2011-04-14 12:16 ` [PATCH 1/2] nand: Fix S3C NAND clock stop Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302665784.14691.5.camel@koala \
--to=dedekind1@gmail.com \
--cc=ben-linux@fluff.org \
--cc=jiri.pinkava@vscht.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).