From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 1/5] ASoC: Make struct snd_soc_card's dapm_widgets and dapm_routes const
Date: Wed, 13 Apr 2011 08:39:02 +0100 [thread overview]
Message-ID: <1302680342.3600.10.camel@odin> (raw)
In-Reply-To: <1302629465-21315-1-git-send-email-lars@metafoo.de>
On Tue, 2011-04-12 at 19:31 +0200, Lars-Peter Clausen wrote:
> Those should not be modified (and are not) by the core code, so make them const.
> This also makes them consistent with the same members of snd_soc_codec.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> include/sound/soc.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/sound/soc.h b/include/sound/soc.h
> index 435cb83..cb6b18b 100644
> --- a/include/sound/soc.h
> +++ b/include/sound/soc.h
> @@ -755,9 +755,9 @@ struct snd_soc_card {
> /*
> * Card-specific routes and widgets.
> */
> - struct snd_soc_dapm_widget *dapm_widgets;
> + const struct snd_soc_dapm_widget *dapm_widgets;
> int num_dapm_widgets;
> - struct snd_soc_dapm_route *dapm_routes;
> + const struct snd_soc_dapm_route *dapm_routes;
> int num_dapm_routes;
>
> struct work_struct deferred_resume_work;
Patch 1,3,4 & 5
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-04-13 7:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 17:31 [PATCH 1/5] ASoC: Make struct snd_soc_card's dapm_widgets and dapm_routes const Lars-Peter Clausen
2011-04-12 17:31 ` [PATCH 2/5] ASoC: Call snd_soc_new_widgets() after registering cards DAPM widgets Lars-Peter Clausen
2011-04-13 0:38 ` Mark Brown
2011-04-13 12:32 ` Lars-Peter Clausen
2011-04-13 17:32 ` Mark Brown
2011-04-13 19:26 ` Lars-Peter Clausen
2011-04-12 17:31 ` [PATCH 3/5] ASoC: JZ4740: Convert qi_lb60 codec to table based DAPM setup Lars-Peter Clausen
2011-04-12 17:31 ` [PATCH 4/5] ASoC: JZ4740: qi_lb60: Use gpio_request_array to request and setup gpios Lars-Peter Clausen
2011-04-12 17:31 ` [PATCH 5/5] ASoC: JZ4740: qi_lb60: Use the SND_SOC_DAPM_EVENT_OFF for the speakers status Lars-Peter Clausen
2011-04-13 7:39 ` Liam Girdwood [this message]
2011-04-13 17:36 ` [PATCH 1/5] ASoC: Make struct snd_soc_card's dapm_widgets and dapm_routes const Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302680342.3600.10.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).