From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: codecs: JZ4740: Fix OOPS
Date: Wed, 13 Apr 2011 08:39:55 +0100 [thread overview]
Message-ID: <1302680395.3600.11.camel@odin> (raw)
In-Reply-To: <1302629609-21537-1-git-send-email-lars@metafoo.de>
On Tue, 2011-04-12 at 19:33 +0200, Lars-Peter Clausen wrote:
> Commit ce6120cc(ASoC: Decouple DAPM from CODECs) changed the signature of
> snd_soc_dapm_widgets_new to take an pointer to a snd_soc_dapm_context instead of
> a snd_soc_codec. The call to snd_soc_dapm_widgets_new in jz4740_codec_dev_probe
> was not updated to reflect this change, which results in a compiletime warning
> and a runtime OOPS.
>
> Since the core code calls snd_soc_dapm_widgets_new after the codec has been
> registered it can be dropped here.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
Both
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-04-13 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 17:33 [PATCH 1/2] ASoC: codecs: JZ4740: Fix OOPS Lars-Peter Clausen
2011-04-12 17:33 ` [PATCH 2/2] ASoC: codecs: JZ4740: Convert to table based controls and DAPM setup Lars-Peter Clausen
2011-04-13 7:39 ` Liam Girdwood [this message]
2011-04-13 17:36 ` [PATCH 1/2] ASoC: codecs: JZ4740: Fix OOPS Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302680395.3600.11.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).