From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933096Ab1DMVjg (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Apr 2011 17:39:36 -0400
Received: from bombadil.infradead.org ([18.85.46.34]:54482 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932906Ab1DMVjf convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Apr 2011 17:39:35 -0400
Subject: Re: [PATCH 01/21] sched: Provide scheduler_ipi() callback in
 response to smp_send_reschedule()
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Tony Luck <tony.luck@intel.com>
Cc: Chris Mason <chris.mason@oracle.com>,
        Frank Rowand <frank.rowand@am.sony.com>, Ingo Molnar <mingo@elte.hu>,
        Thomas Gleixner <tglx@linutronix.de>, Mike Galbraith <efault@gmx.de>,
        Oleg Nesterov <oleg@redhat.com>, Paul Turner <pjt@google.com>,
        Jens Axboe <axboe@kernel.dk>, Yong Zhang <yong.zhang0@gmail.com>,
        linux-kernel@vger.kernel.org,
        Russell King <rmk+kernel@arm.linux.org.uk>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Chris Metcalf <cmetcalf@tilera.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Ralf Baechle <ralf@linux-mips.org>
In-Reply-To: <BANLkTi=+x6+tyHY2uOvE99BXxdreb3Gu=Q@mail.gmail.com>
References: <20110405152338.692966333@chello.nl>
	 <20110405152728.744338123@chello.nl>
	 <BANLkTi=+x6+tyHY2uOvE99BXxdreb3Gu=Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Date: Wed, 13 Apr 2011 23:38:57 +0200
Message-ID: <1302730737.2388.129.camel@twins>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2011-04-13 at 14:15 -0700, Tony Luck wrote:
> On Tue, Apr 5, 2011 at 8:23 AM, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> > --- linux-2.6.orig/arch/ia64/kernel/irq_ia64.c
> > +++ linux-2.6/arch/ia64/kernel/irq_ia64.c
> > @@ -31,6 +31,7 @@
> >  #include <linux/irq.h>
> >  #include <linux/ratelimit.h>
> >  #include <linux/acpi.h>
> > +#include <linux/sched.h>
> >
> >  #include <asm/delay.h>
> >  #include <asm/intrinsics.h>
> > @@ -496,6 +497,7 @@ ia64_handle_irq (ia64_vector vector, str
> >                        smp_local_flush_tlb();
> >                        kstat_incr_irqs_this_cpu(irq, desc);
> >                } else if (unlikely(IS_RESCHEDULE(vector))) {
> > +                       scheduler_ipi();
> >                        kstat_incr_irqs_this_cpu(irq, desc);
> >                } else {
> >                        ia64_setreg(_IA64_REG_CR_TPR, vector);
> 
> This bit breaks ia64 CONFIG_SMP=n builds in next-20110413 with:
> 
> arch/ia64/kernel/irq_ia64.c: In function ‘ia64_handle_irq’:
> arch/ia64/kernel/irq_ia64.c:500: error: implicit declaration of
> function ‘scheduler_ipi’

Ah, I didn't think arch code would have the reschedule interrupt on UP.
I'll provide an empty stub. Thanks!