From: Ben Hutchings <ben@decadent.org.uk>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
Dan Rosenberg <drosenberg@vsecurity.com>,
Alex Elder <aelder@sgi.com>,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
stable-review@kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [Stable-review] [18/74] xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1
Date: Thu, 14 Apr 2011 03:54:45 +0100 [thread overview]
Message-ID: <1302749686.5282.659.camel@localhost> (raw)
In-Reply-To: <20110413155144.895499184@clark.kroah.org>
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On Wed, 2011-04-13 at 08:50 -0700, Greg KH wrote:
> 2.6.32-longterm review patch. If anyone has any objections, please let us know.
>
> ------------------
>
> From: Dan Rosenberg <drosenberg@vsecurity.com>
>
> commit c4d0c3b097f7584772316ee4d64a09fe0e4ddfca upstream.
>
> The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to
> xfs_fs_geometry() with a version number of 3. This code path does not
> fill in the logsunit member of the passed xfs_fsop_geom_t, leading to
> the leaking of four bytes of uninitialized stack data to potentially
> unprivileged callers.
[...]
This caused a serious regression and requires a second fix:
commit af24ee9ea8d532e16883251a6684dfa1be8eec29
Author: Alex Elder <aelder@sgi.com>
Date: Tue Mar 1 17:50:00 2011 +0000
xfs: zero proper structure size for geometry calls
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-04-14 2:54 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 15:54 [00/74] 2.6.32.37-longterm review Greg KH
2011-04-13 15:50 ` [01/74] ALSA: hda - Fix SPDIF out regression on ALC889 Greg KH
2011-04-13 15:50 ` [02/74] ALSA: Fix yet another race in disconnection Greg KH
2011-04-13 15:50 ` [03/74] perf: Better fit max unprivileged mlock pages for tools needs Greg KH
2011-04-13 15:50 ` [04/74] myri10ge: fix rmmod crash Greg KH
2011-04-13 15:50 ` [05/74] cciss: fix lost command issue Greg KH
2011-04-13 15:50 ` [06/74] sound/oss/opl3: validate voice and channel indexes Greg KH
2011-04-13 15:50 ` [07/74] mac80211: initialize sta->last_rx in sta_info_alloc Greg KH
2011-04-13 15:50 ` [08/74] [SCSI] ses: show devices for enclosures with no page 7 Greg KH
2011-04-13 15:50 ` [09/74] [SCSI] ses: Avoid kernel panic when lun 0 is not mapped Greg KH
2011-04-13 15:50 ` [10/74] eCryptfs: Unlock page in write_begin error path Greg KH
2011-04-13 15:50 ` [11/74] eCryptfs: ecryptfs_keyring_auth_tok_for_sig() bug fix Greg KH
2011-04-13 15:50 ` [12/74] staging: usbip: bugfixes related to kthread conversion Greg KH
2011-04-17 20:15 ` Arnd Bergmann
2011-04-18 6:02 ` Greg KH
2011-04-18 8:50 ` Arjan Mels
2011-04-13 15:50 ` [13/74] staging: usbip: bugfix add number of packets for isochronous frames Greg KH
2011-04-13 15:50 ` [14/74] staging: usbip: bugfix for isochronous packets and optimization Greg KH
2011-04-13 15:50 ` [15/74] staging: hv: Fix GARP not sent after Quick Migration Greg KH
2011-04-13 15:50 ` [16/74] staging: hv: use sync_bitops when interacting with the hypervisor Greg KH
2011-04-13 15:50 ` [17/74] Relax si_code check in rt_sigqueueinfo and rt_tgsigqueueinfo Greg KH
2011-04-13 15:50 ` [18/74] xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1 Greg KH
2011-04-14 2:54 ` Ben Hutchings [this message]
2011-04-14 18:27 ` [stable] [Stable-review] " Greg KH
2011-04-13 15:50 ` [19/74] irda: validate peer name and attribute lengths Greg KH
2011-04-13 15:50 ` [20/74] irda: prevent heap corruption on invalid nickname Greg KH
2011-04-13 15:50 ` [21/74] nilfs2: fix data loss in mmap page write for hole blocks Greg KH
2011-04-13 15:50 ` [22/74] ASoC: Explicitly say registerless widgets have no register Greg KH
2011-04-13 15:50 ` [23/74] ALSA: ens1371: fix Creative Ectiva support Greg KH
2011-04-13 15:50 ` [24/74] ROSE: prevent heap corruption with bad facilities Greg KH
2011-04-13 15:50 ` [25/74] Btrfs: Fix uninitialized root flags for subvolumes Greg KH
2011-04-13 15:50 ` [26/74] x86, mtrr, pat: Fix one cpu getting out of sync during resume Greg KH
2011-04-13 15:50 ` [27/74] ath9k: fix a chip wakeup related crash in ath9k_start Greg KH
2011-04-13 15:50 ` [28/74] UBIFS: do not read flash unnecessarily Greg KH
2011-04-13 15:50 ` [29/74] UBIFS: fix oops on error path in read_pnode Greg KH
2011-04-13 15:50 ` [30/74] UBIFS: fix debugging failure in dbg_check_space_info Greg KH
2011-04-13 15:50 ` [31/74] quota: Dont write quota info in dquot_commit() Greg KH
2011-04-14 3:09 ` [Stable-review] " Ben Hutchings
2011-04-14 8:48 ` Jan Kara
2011-04-13 15:50 ` [32/74] mm: avoid wrapping vm_pgoff in mremap() Greg KH
2011-04-13 15:50 ` [33/74] p54usb: IDs for two new devices Greg KH
2011-04-13 15:50 ` [34/74] b43: allocate receive buffers big enough for max frame len + offset Greg KH
2011-04-13 15:50 ` [35/74] Bluetooth: sco: fix information leak to userspace Greg KH
2011-04-13 15:51 ` [36/74] bridge: netfilter: fix information leak Greg KH
2011-04-13 15:51 ` [37/74] Bluetooth: bnep: fix buffer overflow Greg KH
2011-04-13 15:51 ` [38/74] Bluetooth: add support for Apple MacBook Pro 8,2 Greg KH
2011-04-13 15:51 ` [39/74] Treat writes as new when holes span across page boundaries Greg KH
2011-04-13 15:51 ` [40/74] char/tpm: Fix unitialized usage of data buffer Greg KH
2011-04-13 15:51 ` [41/74] netfilter: ip_tables: fix infoleak to userspace Greg KH
2011-04-13 15:51 ` [42/74] netfilter: arp_tables: " Greg KH
2011-04-13 15:51 ` [43/74] netfilter: ipt_CLUSTERIP: fix buffer overflow Greg KH
2011-04-13 15:51 ` [44/74] ipv6: netfilter: ip6_tables: fix infoleak to userspace Greg KH
2011-04-13 15:51 ` [45/74] mfd: ab3100: world-writable debugfs *_priv files Greg KH
2011-04-13 15:51 ` [46/74] drivers/rtc/rtc-ds1511.c: world-writable sysfs nvram file Greg KH
2011-04-13 15:51 ` [47/74] drivers/misc/ep93xx_pwm.c: world-writable sysfs files Greg KH
2011-04-13 15:51 ` [48/74] econet: 4 byte infoleak to the network Greg KH
2011-04-13 15:51 ` [49/74] netfilter: h323: bug in parsing of ASN1 SEQOF field Greg KH
2011-04-13 16:03 ` Patrick McHardy
2011-04-13 16:17 ` Greg KH
2011-04-13 15:51 ` [50/74] sound/oss: remove offset from load_patch callbacks Greg KH
2011-04-13 15:51 ` [51/74] sound: oss: midi_synth: check get_user() return value Greg KH
2011-04-13 15:51 ` [52/74] repair gdbstub to match the gdbserial protocol specification Greg KH
2011-04-13 15:51 ` [53/74] gro: Reset dev pointer on reuse Greg KH
2011-04-13 15:51 ` [54/74] gro: reset skb_iif " Greg KH
2011-04-13 15:51 ` [55/74] x86, amd-ucode: Remove needless log messages Greg KH
2011-04-13 15:51 ` [56/74] x86, microcode, AMD: Extend ucode size verification Greg KH
2011-04-14 3:37 ` [Stable-review] " Ben Hutchings
2011-04-14 7:41 ` Borislav Petkov
2011-04-14 8:18 ` Borislav Petkov
2011-04-15 23:22 ` Henrique de Moraes Holschuh
2011-06-18 21:04 ` [tip:x86/microcode] x86, microcode, AMD: Fix section header size check tip-bot for Borislav Petkov
2011-04-13 15:51 ` [57/74] powerpc/kexec: Add ifdef CONFIG_PPC_STD_MMU_64 to PPC64 code Greg KH
2011-04-13 15:51 ` [58/74] powerpc: Fix default_machine_crash_shutdown #ifdef botch Greg KH
2011-04-13 15:51 ` [59/74] [PATCH] Revert "x86: Cleanup highmap after brk is concluded" Greg KH
2011-04-13 15:51 ` [60/74] Squashfs: handle corruption of directory structure Greg KH
2011-04-13 15:51 ` [61/74] sctp: fix to calc the INIT/INIT-ACK chunk length correctly is set Greg KH
2011-04-13 15:51 ` [62/74] atm/solos-pci: Dont include frame pseudo-header on transmit hex-dump Greg KH
2011-04-13 15:51 ` [63/74] net: ax25: fix information leak to userland Greg KH
2011-04-13 15:51 ` [64/74] net: packet: " Greg KH
2011-04-13 15:51 ` [65/74] ext4: fix credits computing for indirect mapped files Greg KH
2011-04-13 15:51 ` [66/74] nfsd: fix auth_domain reference leak on nlm operations Greg KH
2011-04-13 15:51 ` [67/74] net: tipc: fix information leak to userland Greg KH
2011-04-13 15:51 ` [68/74] inet_diag: Make sure we actually run the same bytecode we audited Greg KH
2011-06-20 19:05 ` [stable] " Paul Gortmaker
2011-04-13 15:51 ` [69/74] econet: Fix crash in aun_incoming() Greg KH
2011-04-13 15:51 ` [70/74] irda: prevent integer underflow in IRLMP_ENUMDEVICES Greg KH
2011-04-13 15:51 ` [71/74] CAN: Use inode instead of kernel address for /proc file Greg KH
2011-04-13 15:51 ` [72/74] exec: make argv/envp memory visible to oom-killer Greg KH
2011-04-13 15:51 ` [73/74] exec: copy-and-paste the fixes into compat_do_execve() paths Greg KH
2011-04-13 15:51 ` [74/74] net: fix rds_iovec page count overflow Greg KH
2011-04-15 16:53 ` [stable] " Paul Gortmaker
2011-04-15 17:10 ` Linus Torvalds
2011-04-15 17:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302749686.5282.659.camel@localhost \
--to=ben@decadent.org.uk \
--cc=aelder@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=drosenberg@vsecurity.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).