From: Mike Galbraith <efault@gmx.de>
To: Paul Menage <menage@google.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Colin Cross <ccross@android.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: query: [PATCH 2/2] cgroup: Remove call to synchronize_rcu in cgroup_attach_task
Date: Thu, 14 Apr 2011 10:44:35 +0200 [thread overview]
Message-ID: <1302770675.7529.2.camel@marge.simson.net> (raw)
In-Reply-To: <1302770084.27576.13.camel@marge.simson.net>
On Thu, 2011-04-14 at 10:34 +0200, Mike Galbraith wrote:
> > > On Wed, 2011-04-13 at 15:16 +0200, Paul Menage wrote:
>
> > > > > + kfree(cgrp);
> > > >
> > > > We might want to punt this through RCU again, in case the subsystem
> > > > destroy() callbacks left anything around that was previously depending
> > > > on the RCU barrier.
>
> Yup, great idea. Two stage teardown/free quenched the fireworks
Correction: made fireworks take longer to ignite. Roughly a minute
after I poked xmit, box exploded. Hohum. BTTODB
-Mike
next prev parent reply other threads:[~2011-04-14 8:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 9:55 query: [PATCH 2/2] cgroup: Remove call to synchronize_rcu in cgroup_attach_task Mike Galbraith
2011-04-13 2:02 ` Li Zefan
2011-04-13 3:11 ` Mike Galbraith
2011-04-13 13:16 ` Paul Menage
2011-04-13 16:56 ` Mike Galbraith
2011-04-14 7:26 ` Mike Galbraith
2011-04-14 8:34 ` Mike Galbraith
2011-04-14 8:44 ` Mike Galbraith [this message]
2011-04-18 14:21 ` Mike Galbraith
2011-04-28 9:38 ` Mike Galbraith
2011-04-29 12:34 ` Mike Galbraith
2011-05-02 13:46 ` Paul E. McKenney
2011-05-02 14:29 ` Mike Galbraith
2011-05-02 15:04 ` Mike Galbraith
2011-05-02 23:03 ` Paul E. McKenney
2011-04-13 13:10 ` Paul Menage
2011-04-13 16:52 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302770675.7529.2.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=a.p.zijlstra@chello.nl \
--cc=ccross@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).