public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: J Freyensee <james_p_freyensee@linux.intel.com>
To: David Rientjes <rientjes@google.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
	suhail.ahmed@intel.com, christophe.guerard@intel.com
Subject: Re: [PATCH 1/4] export kernel call get_task_comm().
Date: Tue, 19 Apr 2011 17:10:22 -0700	[thread overview]
Message-ID: <1303258222.13457.42.camel@localhost> (raw)
In-Reply-To: <alpine.DEB.2.00.1104191620360.4300@chino.kir.corp.google.com>

On Tue, 2011-04-19 at 16:22 -0700, David Rientjes wrote:
> On Tue, 19 Apr 2011, james_p_freyensee@linux.intel.com wrote:
> 
> > From: J Freyensee <james_p_freyensee@linux.intel.com>
> > 
> > This allows drivers who call this function to be compiled modularly.
> > Otherwise, a driver who is interested in this type of functionality
> > has to implement their own get_task_comm() call, causing code
> > duplication in the Linux source tree.
> > 
> > Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
> 
> Acked-by: David Rientjes <rientjes@google.com>
> 
> There've been some other patchsets proposed recently that need to print a 
> thread's comm and since /proc/pid/comm can change the comm's of other 
> threads out from under them, it's necessary to serialize access to it with 
> task_lock().  This patch certainly makes it easier for modules to do so 
> correctly, thanks!

Thanks for the compliment; it's appreciated.  I've made my patch sets
independent from one another.  And I believe a common consensus (at
least with Greg KH, Alan C., Arjan VdV and myself) was achieved that
this is a good patch to apply? So maybe this can be applied to the
kernel, independent of my other patches, so this will fit your needs?



  reply	other threads:[~2011-04-20  0:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-19 22:58 [PATCH 1/4] export kernel call get_task_comm() james_p_freyensee
2011-04-19 23:22 ` David Rientjes
2011-04-20  0:10   ` J Freyensee [this message]
2011-04-20  1:22     ` David Rientjes
2011-04-20  1:43       ` Greg KH
2011-04-20 18:11         ` J Freyensee
2011-04-20 19:14           ` Greg KH
2011-04-20 23:11             ` Andrew Morton
2011-04-20 23:16               ` J Freyensee
2011-04-20 23:46                 ` Andrew Morton
2011-04-21 16:12                   ` J Freyensee
2011-04-20 23:19               ` David Rientjes
  -- strict thread matches above, loose matches on Subject: below --
2011-04-22 23:32 james_p_freyensee
2011-04-25 20:57 ` David Rientjes
2011-05-05 16:59   ` J Freyensee
2011-05-05 18:55     ` David Rientjes
2011-05-06 23:56 james_p_freyensee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303258222.13457.42.camel@localhost \
    --to=james_p_freyensee@linux.intel.com \
    --cc=christophe.guerard@intel.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=suhail.ahmed@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox