From: J Freyensee <james_p_freyensee@linux.intel.com>
To: David Rientjes <rientjes@google.com>
Cc: akpm@linux-foundattion.org, gregkh@suse.de,
linux-kernel@vger.kernel.org, suhail.ahmed@intel.com,
christophe.guerard@intel.com
Subject: Re: [PATCH] export kernel call get_task_comm().
Date: Fri, 22 Apr 2011 15:43:59 -0700 [thread overview]
Message-ID: <1303512239.13457.123.camel@localhost> (raw)
In-Reply-To: <alpine.DEB.2.00.1104221534380.3873@chino.kir.corp.google.com>
On Fri, 2011-04-22 at 15:35 -0700, David Rientjes wrote:
> On Fri, 22 Apr 2011, james_p_freyensee@linux.intel.com wrote:
>
> > From: J Freyensee <james_p_freyensee@linux.intel.com>
> >
> > This allows drivers who call this function to be compiled modularly.
> > Otherwise, a driver who is interested in this type of functionality
> > has to implement their own get_task_comm() call, causing code
> > duplication in the Linux source tree.
> >
> > Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> I still suggest that we implement finer-grained protection for tsk->comm
> through get_task_comm(), though, because it's going to be difficult to
> know whether task_lock(tsk) is held in all contexts we'll want to call it;
> task_lock(tsk) is used to protect many members of task_struct.
Okay, but how about accepting this as step 1, then investigate a finer
grained lock structure as step 2?
next prev parent reply other threads:[~2011-04-22 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 22:26 [PATCH] export kernel call get_task_comm() james_p_freyensee
2011-04-22 22:35 ` David Rientjes
2011-04-22 22:43 ` J Freyensee [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-22 22:35 james_p_freyensee
2011-04-22 22:43 ` Greg KH
2011-04-22 22:59 ` J Freyensee
2011-04-22 23:04 ` Greg KH
2011-04-22 23:08 ` J Freyensee
2011-04-22 23:17 ` Greg KH
2011-04-22 23:19 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303512239.13457.123.camel@localhost \
--to=james_p_freyensee@linux.intel.com \
--cc=akpm@linux-foundattion.org \
--cc=christophe.guerard@intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=suhail.ahmed@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox