public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Michal Marek <mmarek@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-kbuild@vger.kernel.org,
	Roman Zippel <zippel@linux-m68k.org>
Subject: Re: [PATCH] kconfig: Avoid buffer underrun in choice input
Date: Sun, 24 Apr 2011 05:02:01 +0100	[thread overview]
Message-ID: <1303617721.3032.88.camel@localhost> (raw)
In-Reply-To: <20110423180450.GB25379@merkur.ravnborg.org>

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

On Sat, 2011-04-23 at 20:04 +0200, Sam Ravnborg wrote:
> On Sat, Apr 23, 2011 at 06:42:56PM +0100, Ben Hutchings wrote:
> > commit 40aee729b350672c2550640622416a855e27938f ('kconfig: fix default
> > value for choice input') fixed some cases where kconfig would select
> > the wrong option from a choice with a single valid option and thus
> > enter an infinite loop.
> > 
> > However, this broke the test for user input of the form 'N?', because
> > when kconfig selects the single valid option the input is zero-length
> > and the test will read the byte before the input buffer.  If this
> > happens to contain '?' (as it will in a mips build on Debian unstable
> > today) then kconfig again enters an infinite loop.
> > 
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > Cc: stable@kernel.org [2.6.17+]
> > ---
> > Roman has failed to respond to this after 5 weeks and one reminder, so
> > please take it directly.
> 
> No-one has heard from Roman Zippel in several years.
> I have suggested Michal Marek to take over the maintainer
> role - as he in practice is the kconfig maintainer.

Can someone please update MAINTAINERS then?  What is the point of it if
people don't update it for years?

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2011-04-24  4:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-23 17:42 [PATCH] kconfig: Avoid buffer underrun in choice input Ben Hutchings
2011-04-23 18:04 ` Sam Ravnborg
2011-04-24  4:02   ` Ben Hutchings [this message]
2011-04-24  8:39     ` Geert Uytterhoeven
2011-04-27 11:19 ` Michal Marek
2011-04-27 13:12   ` Ben Hutchings
2011-04-27 17:35   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303617721.3032.88.camel@localhost \
    --to=ben@decadent.org.uk \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox