From: Joe Perches <joe@perches.com>
To: "Jimmy Chen (陳永達)" <jimmy.chen@moxa.com>
Cc: linux-kernel@vger.kernel.org, gregkh@suse.de
Subject: RE: [PATCH 2/2] misc: add real function open/read/write/ioctl/close for moxa_serial_io driver
Date: Sun, 24 Apr 2011 19:47:23 -0700 [thread overview]
Message-ID: <1303699643.1745.7.camel@Joe-Laptop> (raw)
In-Reply-To: <ECB3782BB8F03341905DD923270296115D5AC2@mhqms01.moxa.com>
On Mon, 2011-04-25 at 10:35 +0800, Jimmy Chen (陳永達) wrote:
> Add real function and GPL license.
> Signed-off-by: Jimmy Chen <jimmy.chen@moxa.com>
A few things.
o Your patches are reversed.
o Please run your patches through checkpatch.
o I think it better to avoid duplicating all of the GPL
and just reference it as you have via MODULE_LICENSE.
o You could probably use MODULE_LICENSE("GPL V2")
if you want to limit it to V2 only.
next prev parent reply other threads:[~2011-04-25 2:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 10:07 [PATCH 0/2] misc: add support to MOXA V2100 serial io driver Jimmy Chen (陳永達)
2011-04-25 2:28 ` [PATCH 1/2] misc: add option in menu to support " Jimmy Chen (陳永達)
2011-04-25 2:35 ` [PATCH 2/2] misc: add real function open/read/write/ioctl/close for moxa_serial_io driver Jimmy Chen (陳永達)
2011-04-25 2:47 ` Joe Perches [this message]
2011-04-25 3:01 ` Greg KH
2011-04-25 3:44 ` Jimmy Chen (陳永達)
2011-04-25 14:13 ` Greg KH
2011-04-26 9:01 ` Jimmy Chen (陳永達)
2011-04-26 13:20 ` Greg KH
2011-04-25 11:40 ` Alan Cox
2011-04-25 11:34 ` [PATCH 1/2] misc: add option in menu to support MOXA V2100 serial io driver Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2011-04-25 6:44 [PATCH 2/2] misc: add real function open/read/write/ioctl/close for moxa_serial_io driver Jimmy Chen (陳永達)
2011-04-25 7:30 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303699643.1745.7.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=gregkh@suse.de \
--cc=jimmy.chen@moxa.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox