From: Joe Perches <joe@perches.com>
To: Kenji Toyama <kenji.toyama@gmail.com>
Cc: gregkh@suse.de, aaro.koskinen@iki.fi, wfp5p@virginia.edu,
martinez.javier@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: xgifb: Fixed style issues.
Date: Mon, 25 Apr 2011 21:21:32 -0700 [thread overview]
Message-ID: <1303791692.24299.23.camel@Joe-Laptop> (raw)
In-Reply-To: <1303791159-8042-1-git-send-email-kenji.toyama@gmail.com>
On Tue, 2011-04-26 at 12:12 +0800, Kenji Toyama wrote:
> Now there's only 10 errors and 1 warning given by checkpatch.pl, and
> these are related initialization of statics. The only warning left can
> be safely ignored I believe.
[]
> static DEFINE_PCI_DEVICE_TABLE(xgifb_pci_table) = {
> - { PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_20, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> - { PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_27, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> - { PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_40, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 2},
> - { PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_42, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 3},
> - { 0 }
> + {PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_20, PCI_ANY_ID, PCI_ANY_ID,
> + 0, 0, 0},
> + {PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_27, PCI_ANY_ID, PCI_ANY_ID,
> + 0, 0, 1},
> + {PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_40, PCI_ANY_ID, PCI_ANY_ID,
> + 0, 0, 2},
> + {PCI_VENDOR_ID_XG, PCI_DEVICE_ID_XG_42, PCI_ANY_ID, PCI_ANY_ID,
> + 0, 0, 3},
> + {0}
Not an improvement.
You might use PCI_VDEVICE.
> #define MODE_INDEX_NONE 0 /* TW: index for mode=none */
> - {"none", 0xFF, 0x0000, 0x0000, 0, 0, 0, 0, 0, 0, MD_XGI300|MD_XGI315}, /* TW: for mode "none" */
[]
> + {"none", 0xFF, 0x0000, 0x0000, 0, 0, 0, 0, 0, 0,
> + MD_XGI300|MD_XGI315}, /* TW: for mode "none" */
Again, not an improvement.
Not everything needs to be 80 columns.
prev parent reply other threads:[~2011-04-26 4:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 4:12 [PATCH] Staging: xgifb: Fixed style issues Kenji Toyama
2011-04-26 4:21 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303791692.24299.23.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=aaro.koskinen@iki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=kenji.toyama@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox