From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757419Ab1D1D5b (ORCPT ); Wed, 27 Apr 2011 23:57:31 -0400 Received: from mail-gy0-f174.google.com ([209.85.160.174]:49665 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754154Ab1D1D5a (ORCPT ); Wed, 27 Apr 2011 23:57:30 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=YU/BRx+WMNLFILi10QxTmzVBXOiflaxEMUrSbKOAzDnZGAWxFQNgwP5aWnh+/neAd3 ZtA/ta8+Dex0FhdsOTaPqzIxF/CLiPtmA6u3aBLDTYMS7Z234jRJvXxf+Vx7XLC+F0My 4chBMN0VY6WDTfhyUY6vq8JagW7ywEah548Nw= Subject: [PATCH] Input: twl4030-pwrbutton - fix a leak of the IRQ during init failure From: Axel Lin To: linux-kernel@vger.kernel.org Cc: Peter De Schrijver , Felipe Balbi , Dmitry Torokhov , linux-input@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Date: Thu, 28 Apr 2011 11:57:21 +0800 Message-ID: <1303963041.2588.3.camel@phoenix> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In twl4030_pwrbutton_probe error path, free_irq() was using NULL rather than the driver data as the data pointer so free_irq() wouldn't have matched. Signed-off-by: Axel Lin --- drivers/input/misc/twl4030-pwrbutton.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c index f16972b..38e4b50 100644 --- a/drivers/input/misc/twl4030-pwrbutton.c +++ b/drivers/input/misc/twl4030-pwrbutton.c @@ -89,7 +89,7 @@ static int __init twl4030_pwrbutton_probe(struct platform_device *pdev) return 0; free_irq: - free_irq(irq, NULL); + free_irq(irq, pwr); free_input_dev: input_free_device(pwr); return err; -- 1.7.1