From: David Decotigny <decot@google.com>
To: "David S. Miller" <davem@davemloft.net>,
Ben Hutchings <bhutchings@solarflare.com>,
mirq-linux@rere.qmqm.pl, Stanislaw Gruszka <sgruszka@redhat.com>,
Alexander Duyck <alexander.h.duyck@intel.com>,
Eilon Greenstein <eilong@broadcom.com>,
Grant Grundler <grundler@parisc-linux.org>,
e1000-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Cc: David Decotigny <decot@google.com>
Subject: [PATCHv4 6/7] tulip/de2104x: don't report different speeds depending on port type
Date: Wed, 27 Apr 2011 21:32:42 -0700 [thread overview]
Message-ID: <1303965163-8198-7-git-send-email-decot@google.com> (raw)
In-Reply-To: <1303965163-8198-1-git-send-email-decot@google.com>
Initial driver reported different speeds depending on the port being
used. This advertises the speed to be 10Mbps in any case, which is
what it actually is on the wire.
Signed-off-by: David Decotigny <decot@google.com>
---
drivers/net/tulip/de2104x.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
index ab78e1d..46d5a1b 100644
--- a/drivers/net/tulip/de2104x.c
+++ b/drivers/net/tulip/de2104x.c
@@ -1518,18 +1518,17 @@ static int __de_get_settings(struct de_private *de, struct ethtool_cmd *ecmd)
switch (de->media_type) {
case DE_MEDIA_AUI:
ecmd->port = PORT_AUI;
- ethtool_cmd_speed_set(ecmd, 5);
break;
case DE_MEDIA_BNC:
ecmd->port = PORT_BNC;
- ethtool_cmd_speed_set(ecmd, 2);
break;
default:
ecmd->port = PORT_TP;
- ethtool_cmd_speed_set(ecmd, SPEED_10);
break;
}
+ ethtool_cmd_speed_set(ecmd, 10);
+
if (dr32(MacMode) & FullDuplex)
ecmd->duplex = DUPLEX_FULL;
else
@@ -1549,11 +1548,8 @@ static int __de_set_settings(struct de_private *de, struct ethtool_cmd *ecmd)
{
u32 new_media;
unsigned int media_lock;
- u32 speed = ethtool_cmd_speed(ecmd);
- if (speed != SPEED_10 && speed != 5 && speed != 2)
- return -EINVAL;
- if (de->de21040 && speed == 2)
+ if (ethtool_cmd_speed(ecmd) != 10)
return -EINVAL;
if (ecmd->duplex != DUPLEX_HALF && ecmd->duplex != DUPLEX_FULL)
return -EINVAL;
--
1.7.3.1
next prev parent reply other threads:[~2011-04-28 4:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 4:32 [PATCHv4 0/7] ethtool: generalize use of ethtool_cmd_speed API David Decotigny
2011-04-28 4:32 ` [PATCHv4 1/7] ethtool: cosmetics: enforce const-ness in ethtool_cmd_speed David Decotigny
2011-04-28 4:32 ` [PATCHv4 2/7] ethtool: Call ethtool's get/set_settings callbacks with cleaned data David Decotigny
2011-04-28 7:34 ` Stanislaw Gruszka
2011-04-28 12:46 ` Ben Hutchings
2011-04-28 15:16 ` David Decotigny
2011-04-28 4:32 ` [PATCHv4 3/7] ethtool: Use full 32 bit speed range in ethtool's set_settings David Decotigny
2011-04-28 4:32 ` [PATCHv4 4/7] ethtool: cosmetic: Use ethtool ethtool_cmd_speed API David Decotigny
2011-04-28 4:32 ` [PATCHv4 5/7] acenic: Fix using the specified speed when configuring NIC David Decotigny
2011-04-28 4:32 ` David Decotigny [this message]
2011-04-28 4:32 ` [PATCHv4 7/7] net/igb/e1000/e1000e: more robust ethtool duplex/speed configuration David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303965163-8198-7-git-send-email-decot@google.com \
--to=decot@google.com \
--cc=alexander.h.duyck@intel.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=grundler@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox