From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
Omar Ramirez Luna <omar.ramirez@ti.com>,
Fernando Guzman Lugo <x0095840@ti.com>,
Ohad Ben-Cohen <ohad@wizery.com>, Nishanth Menon <nm@ti.com>,
lkml <linux-kernel@vger.kernel.org>,
devel <devel@driverdev.osuosl.org>
Subject: [PATCH v4 1/6] staging: tidspbridge: introduce mapping search based on device address
Date: Thu, 28 Apr 2011 10:31:47 -0500 [thread overview]
Message-ID: <1304004712-8487-2-git-send-email-omar.ramirez@ti.com> (raw)
In-Reply-To: <1304004712-8487-1-git-send-email-omar.ramirez@ti.com>
Create function find_containing_mapping_da to search mapping objects
given the dsp va instead of the mpu va, in preparation to delete dmm
functions altogether.
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
drivers/staging/tidspbridge/rmgr/proc.c | 41 +++++++++++++++++++++++++++++-
1 files changed, 39 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr/proc.c b/drivers/staging/tidspbridge/rmgr/proc.c
index 242dd13..214dff8 100644
--- a/drivers/staging/tidspbridge/rmgr/proc.c
+++ b/drivers/staging/tidspbridge/rmgr/proc.c
@@ -231,6 +231,37 @@ out:
return map_obj;
}
+static struct dmm_map_object *find_containing_mapping_da(
+ struct process_context *pr_ctxt,
+ u32 dsp_addr)
+{
+ struct dmm_map_object *map_obj;
+
+ pr_debug("%s: looking for virt 0x%x\n", __func__, dsp_addr);
+
+ spin_lock(&pr_ctxt->dmm_map_lock);
+ list_for_each_entry(map_obj, &pr_ctxt->dmm_map_list, link) {
+ pr_debug("%s: candidate: mpu_addr 0x%x virt 0x%x size 0x%x\n",
+ __func__,
+ map_obj->mpu_addr,
+ map_obj->dsp_addr,
+ map_obj->size);
+
+ if (map_obj->dsp_addr == dsp_addr) {
+ pr_debug("%s: match!\n", __func__);
+ goto out;
+ }
+ pr_debug("%s: candidate didn't match\n", __func__);
+ }
+
+ map_obj = NULL;
+
+ pr_err("%s: failed to find given map info\n", __func__);
+out:
+ spin_unlock(&pr_ctxt->dmm_map_lock);
+ return map_obj;
+}
+
static int find_first_page_in_cache(struct dmm_map_object *map_obj,
unsigned long mpu_addr)
{
@@ -1703,6 +1734,7 @@ int proc_un_map(void *hprocessor, void *map_addr,
int status = 0;
struct proc_object *p_proc_object = (struct proc_object *)hprocessor;
struct dmm_object *dmm_mgr;
+ struct dmm_map_object *dmo;
u32 va_align;
u32 size_align;
@@ -1725,10 +1757,15 @@ int proc_un_map(void *hprocessor, void *map_addr,
* This function returns error if the VA is not mapped
*/
status = dmm_un_map_memory(dmm_mgr, (u32) va_align, &size_align);
+
+ dmo = find_containing_mapping_da(pr_ctxt, (u32)map_addr);
+ if (!dmo)
+ goto unmap_failed;
+
/* Remove mapping from the page tables. */
if (!status) {
status = (*p_proc_object->intf_fxns->brd_mem_un_map)
- (p_proc_object->bridge_context, va_align, size_align);
+ (p_proc_object->bridge_context, va_align, dmo->size);
}
if (status)
@@ -1739,7 +1776,7 @@ int proc_un_map(void *hprocessor, void *map_addr,
* from dmm_map_list, so that mapped memory resource tracking
* remains uptodate
*/
- remove_mapping_information(pr_ctxt, (u32) map_addr, size_align);
+ remove_mapping_information(pr_ctxt, (u32) map_addr, dmo->size);
unmap_failed:
mutex_unlock(&proc_lock);
--
1.7.1
next prev parent reply other threads:[~2011-04-28 15:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 15:31 [PATCH v4 0/6] staging tidspbridge: iommu migration Omar Ramirez Luna
2011-04-28 15:31 ` Omar Ramirez Luna [this message]
2011-04-28 15:31 ` [PATCH v4 2/6] staging: tidspbridge: replace custom mmu for omap iommu framework Omar Ramirez Luna
2011-04-28 15:31 ` [PATCH v4 3/6] staging: tidspbridge: mapping support when SG_CHAIN is not defined Omar Ramirez Luna
2011-04-28 15:31 ` [PATCH v4 4/6] staging: tidspbridge: remove custom mmu code Omar Ramirez Luna
2011-04-28 15:31 ` [PATCH v4 5/6] staging: tidspbridge: remove dmm module Omar Ramirez Luna
2011-04-28 15:31 ` [PATCH v4 6/6] staging: tidspbridge: decouple mmu functions from regular code Omar Ramirez Luna
2011-05-03 17:55 ` [PATCH v4 0/6] staging tidspbridge: iommu migration Greg KH
2011-05-03 20:34 ` Ramirez Luna, Omar
2011-05-03 20:18 ` Arnd Bergmann
2011-05-03 20:48 ` Ramirez Luna, Omar
2011-05-04 13:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304004712-8487-2-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=devel@driverdev.osuosl.org \
--cc=felipe.contreras@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=ohad@wizery.com \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox