From: "wanlong.gao" <wanlong.gao@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix the over time interface of the driver-model docs
Date: Mon, 02 May 2011 17:02:59 +0800 [thread overview]
Message-ID: <1304326979.1777.1.camel@Tux> (raw)
In-Reply-To: <20110502032906.GA1553@kroah.com>
在 2011-05-01日的 20:29 -0700,Greg KH写道:
> On Sun, May 01, 2011 at 07:59:39PM -0700, Randy Dunlap wrote:
> > On Sun, 1 May 2011 13:50:56 +0800 wanlong.gao@gmail.com wrote:
> >
> > > From: Wanlong Gao<wanlong.gao@gmail.com>
> > >
> > > The driver-model documentation seems like out-of-date, Can we
> > > fix them or rewrite ?
> >
> > GregKH should get this patch.......
> >
> >
> > > Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com>
> > > ---
> > > Documentation/driver-model/bus.txt | 32 ++++----
> > > Documentation/driver-model/device.txt | 149 +++++++++++++++++++--------------
> > > 2 files changed, 104 insertions(+), 77 deletions(-)
> > >
> > > diff --git a/Documentation/driver-model/bus.txt b/Documentation/driver-model/bus.txt
> > > index 5001b75..82bca26 100644
> > > --- a/Documentation/driver-model/bus.txt
> > > +++ b/Documentation/driver-model/bus.txt
> > > @@ -5,21 +5,23 @@ Definition
> > > ~~~~~~~~~~
> > >
> > > struct bus_type {
> > > - char * name;
> > > + const char *name;
> > > + struct bus_attribute *bus_attrs;
> > > + struct device_attribute *dev_attrs;
> > > + struct driver_attribute *drv_attrs;
>
>
> <snip>
>
> This should almost all removed from these files and moved to be
> kerneldoc in the device.h file instead. That will keep things up to
> date and provide a better way to document this stuff.
>
> Wanlong, can you do that instead?
>
> thanks,
>
> greg k-h
Greg:
I see, I'll try to do it .
Thanks
Best regards
Wanlong Gao
prev parent reply other threads:[~2011-05-02 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-01 5:50 [PATCH] Fix the over time interface of the driver-model docs wanlong.gao
2011-05-02 2:59 ` Randy Dunlap
2011-05-02 3:29 ` Greg KH
2011-05-02 9:02 ` wanlong.gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304326979.1777.1.camel@Tux \
--to=wanlong.gao@gmail.com \
--cc=greg@kroah.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox