From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, arnd@arndb.de, akpm@linux-foundation.org,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 4/4] Remove last BKL leftover: lock_depth
Date: Fri, 6 May 2011 14:05:28 -0700 [thread overview]
Message-ID: <1304715928-19266-5-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1304715928-19266-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
This was the (hopefully) last BKL leftover: the per task lock_depth
field.
After all users are gone remove the task_struct lock_depth field.
Depending on the configuration this will not actually shrink task_struct
unfortunately due to padding. It helps a bit on 32bit. And on 64bit
it allows new bloat.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
include/linux/init_task.h | 1 -
include/linux/sched.h | 2 --
kernel/fork.c | 1 -
3 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/include/linux/init_task.h b/include/linux/init_task.h
index caa151f..689496b 100644
--- a/include/linux/init_task.h
+++ b/include/linux/init_task.h
@@ -134,7 +134,6 @@ extern struct cred init_cred;
.stack = &init_thread_info, \
.usage = ATOMIC_INIT(2), \
.flags = PF_KTHREAD, \
- .lock_depth = -1, \
.prio = MAX_PRIO-20, \
.static_prio = MAX_PRIO-20, \
.normal_prio = MAX_PRIO-20, \
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 53373bc..006c31f 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1193,8 +1193,6 @@ struct task_struct {
unsigned int flags; /* per process flags, defined below */
unsigned int ptrace;
- int lock_depth; /* BKL lock depth */
-
#ifdef CONFIG_SMP
#ifdef __ARCH_WANT_UNLOCKED_CTXSW
int oncpu;
diff --git a/kernel/fork.c b/kernel/fork.c
index e7548de..aca6287 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1103,7 +1103,6 @@ static struct task_struct *copy_process(unsigned long clone_flags,
posix_cpu_timers_init(p);
- p->lock_depth = -1; /* -1 = no lock */
do_posix_clock_monotonic_gettime(&p->start_time);
p->real_start_time = p->start_time;
monotonic_to_bootbased(&p->real_start_time);
--
1.7.4.4
next prev parent reply other threads:[~2011-05-06 21:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 21:05 Remove last BKL leftover: lock_depth Andi Kleen
2011-05-06 21:05 ` [PATCH 1/4] BKL: Remove BKL references in mutex code Andi Kleen
2011-05-06 21:05 ` [PATCH 2/4] SCHED: Remove BKL accounting from schedstats Andi Kleen
2011-05-07 8:16 ` Ingo Molnar
2011-05-06 21:05 ` [PATCH 3/4] SCHED: Don't use BKL count for idle preempt count initialization Andi Kleen
2011-05-06 21:05 ` Andi Kleen [this message]
2011-05-06 21:11 ` Remove last BKL leftover: lock_depth Andrew Morton
2011-05-06 21:19 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304715928-19266-5-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox