From: Liam Girdwood <lrg@kernel.org>
To: balbi@ti.com
Cc: Graeme Gregory <gg@slimlogic.co.uk>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
sameo@linux.intel.com, broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/4] MFD: TWL6025: add phoenix lite support to twl6030
Date: Sun, 08 May 2011 21:32:33 +0100 [thread overview]
Message-ID: <1304886753.3246.22.camel@odin> (raw)
In-Reply-To: <20110427104001.GX13227@legolas.emea.dhcp.ti.com>
On Wed, 2011-04-27 at 13:40 +0300, Felipe Balbi wrote:
> On Wed, Apr 27, 2011 at 10:39:48AM +0100, Graeme Gregory wrote:
> > + /* TWL6025 LDO regulators */
> > + struct regulator_init_data *ldo1;
> > + struct regulator_init_data *ldo2;
> > + struct regulator_init_data *ldo3;
> > + struct regulator_init_data *ldo4;
> > + struct regulator_init_data *ldo5;
> > + struct regulator_init_data *ldo6;
> > + struct regulator_init_data *ldo7;
> > + struct regulator_init_data *ldoln;
> > + struct regulator_init_data *ldousb;
> > + /* TWL6025 DCDC regulators */
> > + struct regulator_init_data *smps3;
> > + struct regulator_init_data *smps4;
> > + struct regulator_init_data *vio6025;
>
> this is just becoming really really ugly. You need a more clever way of
> handling this. Maybe passing an array of regulators and the array size
> instead of continuously adding fields to this structure.
>
Ok, I agree that optimising the platform data here is desirable, but I
think we will have to stick with this atm as the twl driver has some
rather annoying limitations that make optimising things like this a pita
atm.
I guess we should look at fixing the twl driver within TI in order to
make it more adaptable (i.e. support future twl ICs) and also a non
singleton device.
Liam
next prev parent reply other threads:[~2011-05-08 20:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 9:39 [PATCH 0/4] Add support for twl6025 PMIC Graeme Gregory
2011-04-27 9:39 ` [PATCH 1/4] MFD: TWL6025: add phoenix lite support to twl6030 Graeme Gregory
2011-04-27 10:40 ` Felipe Balbi
2011-05-08 20:32 ` Liam Girdwood [this message]
2011-04-27 9:39 ` [PATCH 2/4] MFD: TWL6030: fix irq definitions Graeme Gregory
2011-04-27 9:39 ` [PATCH 3/4] REGULATOR: TWL6025: add support to twl-regulator Graeme Gregory
2011-04-27 10:43 ` Felipe Balbi
2011-04-27 11:08 ` Mark Brown
2011-04-27 9:39 ` [PATCH 4/4] USB: TWL6025 allow different regulator name Graeme Gregory
2011-04-27 10:45 ` Felipe Balbi
2011-05-08 15:08 ` Liam Girdwood
2011-05-09 9:03 ` Felipe Balbi
2011-05-09 11:43 ` Liam Girdwood
2011-05-09 12:16 ` Felipe Balbi
2011-05-09 12:29 ` Mark Brown
2011-05-09 13:07 ` Felipe Balbi
2011-05-09 13:35 ` Mark Brown
2011-05-09 13:51 ` Felipe Balbi
2011-05-09 15:17 ` Mark Brown
2011-05-09 13:11 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304886753.3246.22.camel@odin \
--to=lrg@kernel.org \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).