public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel J Blueman <daniel.blueman@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, H Peter Anvin <hpa@zytor.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Daniel J Blueman <daniel.blueman@gmail.com>
Subject: [PATCH] ioapic: fix potential resume deadlock
Date: Mon,  9 May 2011 10:40:14 +0800	[thread overview]
Message-ID: <1304908814-23369-1-git-send-email-daniel.blueman@gmail.com> (raw)

Fix a potential deadlock when resuming; here the calling function
has disabled interrupts, so we cannot sleep.

Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>

---
 arch/x86/kernel/apic/io_apic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 45fd33d..df63620 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -621,14 +621,14 @@ struct IO_APIC_route_entry **alloc_ioapic_entries(void)
 	struct IO_APIC_route_entry **ioapic_entries;
 
 	ioapic_entries = kzalloc(sizeof(*ioapic_entries) * nr_ioapics,
-				GFP_KERNEL);
+				GFP_ATOMIC);
 	if (!ioapic_entries)
 		return 0;
 
 	for (apic = 0; apic < nr_ioapics; apic++) {
 		ioapic_entries[apic] =
 			kzalloc(sizeof(struct IO_APIC_route_entry) *
-				nr_ioapic_registers[apic], GFP_KERNEL);
+				nr_ioapic_registers[apic], GFP_ATOMIC);
 		if (!ioapic_entries[apic])
 			goto nomem;
 	}
-- 
1.7.4.1


             reply	other threads:[~2011-05-09  2:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-09  2:40 Daniel J Blueman [this message]
2011-05-10  5:32 ` [PATCH] ioapic: fix potential resume deadlock Daniel J Blueman
2011-05-10  7:35 ` Ingo Molnar
2011-05-10 10:53   ` Daniel J Blueman
2011-05-10 23:58     ` Suresh Siddha
2011-05-11 16:15       ` Daniel J Blueman
2011-05-13 17:48         ` Suresh Siddha
2011-05-14 14:39           ` Daniel J Blueman
2011-05-16 11:32             ` Ingo Molnar
2011-05-16 17:04               ` Suresh Siddha
2011-05-16 11:34           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304908814-23369-1-git-send-email-daniel.blueman@gmail.com \
    --to=daniel.blueman@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox