From: Joe Perches <joe@perches.com>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org, qi.wang@intel.com,
yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com, toshiharu-linux@dsn.okisemi.com
Subject: Re: [PATCH V2 2/5] pch_dma: modify for checkpatch
Date: Sun, 08 May 2011 21:02:00 -0700 [thread overview]
Message-ID: <1304913720.19586.4.camel@Joe-Laptop> (raw)
In-Reply-To: <1304912406-6531-2-git-send-email-tomoya-linux@dsn.okisemi.com>
On Mon, 2011-05-09 at 12:40 +0900, Tomoya MORINAGA wrote:
> Fix checkpatch warnings.
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
[]
> @@ -138,7 +138,8 @@ struct pch_dma {
> -static inline struct pch_dma_desc *to_pd_desc(struct dma_async_tx_descriptor *txd)
> +static inline struct pch_dma_desc *to_pd_desc(
> + struct dma_async_tx_descriptor *txd)
I think these are better either not changed at all
or to either of the styles below:
static inline struct pch_dma_desc *
to_pd_desc(struct dma_async_tx_descriptor *txd)
static inline
struct pch_dma_desc *to_pd_desc(struct dma_async_tx_descriptor *txd)
next prev parent reply other threads:[~2011-05-09 4:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 3:40 [PATCH V2 1/5] pch_dma: fix dma direction issue for ML7213 IOH video-in Tomoya MORINAGA
2011-05-09 3:40 ` [PATCH V2 2/5] pch_dma: modify for checkpatch Tomoya MORINAGA
2011-05-09 4:02 ` Joe Perches [this message]
2011-05-09 5:27 ` Tomoya MORINAGA
2011-05-09 3:40 ` [PATCH V2 3/5] pch_dma: Fix DMA setting issue Tomoya MORINAGA
2011-05-09 3:40 ` [PATCH V2 4/5] pch_dma: Support I2S for ML7213 IOH Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304913720.19586.4.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=dan.j.williams@intel.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=toshiharu-linux@dsn.okisemi.com \
--cc=vinod.koul@intel.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox