Re: [PATCH 077/206] Staging: hv: Get rid of call to cleanup()

Greg KH
2011-05-09T22:53:33Z

On Mon, May 09, 2011 at 02:55:59PM -0700, K. Y. Srinivasan wrote:
> cleanup() is an empty function; get rid of it.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
> Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
> ---
> drivers/staging/hv/netvsc_drv.c | 4 ----

Just picking a random patch out of this series (which, I only received
the first 132, not all 206).

You need to specify a better changelog entry as you didn't say what code
you are changing in the Subject:.

How about:
Staging: hv: netvsc_drv: Get rid of call to cleanup()

Otherwise I would think (and I did) that you got rid of a global
function called cleanup() in all of the hv code.

Care to fix the names of your patches?

Note, I wouldn't recommend sending that many patches to lkml, it's not
needed, just stick to the devel@linuxdriverproject.org list as I really
doubt anyone else cares about this code at the moment.

thanks,

greg k-h