From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
kernel@pengutronix.de,
H Hartley Sweeten <hartleys@visionengravers.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [wip] ARM: imx: register "leds-gpio" device using new helper function
Date: Tue, 10 May 2011 10:50:56 +0200 [thread overview]
Message-ID: <1305017456-10910-2-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <1305017456-10910-1-git-send-email-u.kleine-koenig@pengutronix.de>
This converts eukrea_mbimx27-baseboard to the new helper function.
bloat-o-meter reports for this change:
add/remove: 1/1 grow/shrink: 0/1 up/down: 128/-220 (-92)
function old new delta
gpio_led_register_device - 128 +128
platform_devices 28 24 -4
leds_gpio 216 - -216
Additionally gpio_led_info (12 bytes) and gpio_leds (32 Bytes) are
initdata now as is gpio_led_register_device.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
This is just an example and probably doesn't apply to the imx tree as
is. I will convert all imx machines when there's an agreement for the
patch providing the helper function.
arch/arm/mach-imx/Kconfig | 1 +
arch/arm/mach-imx/eukrea_mbimx27-baseboard.c | 18 +++---------------
2 files changed, 4 insertions(+), 15 deletions(-)
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 56b930a..ef16471 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -222,6 +222,7 @@ choice
config MACH_EUKREA_MBIMX27_BASEBOARD
bool "Eukrea MBIMX27 development board"
+ select LEDS_GPIO_REGISTER
select IMX_HAVE_PLATFORM_IMX_FB
select IMX_HAVE_PLATFORM_IMX_KEYPAD
select IMX_HAVE_PLATFORM_IMX_SSI
diff --git a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
index fa5288018..3479f66 100644
--- a/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
+++ b/arch/arm/mach-imx/eukrea_mbimx27-baseboard.c
@@ -113,7 +113,7 @@ eukrea_mbimx27_keymap_data __initconst = {
.keymap_size = ARRAY_SIZE(eukrea_mbimx27_keymap),
};
-static struct gpio_led gpio_leds[] = {
+static const struct gpio_led gpio_leds[] __initconst = {
{
.name = "led1",
.default_trigger = "heartbeat",
@@ -128,19 +128,11 @@ static struct gpio_led gpio_leds[] = {
},
};
-static struct gpio_led_platform_data gpio_led_info = {
+static const struct gpio_led_platform_data gpio_led_info __initconst = {
.leds = gpio_leds,
.num_leds = ARRAY_SIZE(gpio_leds),
};
-static struct platform_device leds_gpio = {
- .name = "leds-gpio",
- .id = -1,
- .dev = {
- .platform_data = &gpio_led_info,
- },
-};
-
static struct imx_fb_videomode eukrea_mbimx27_modes[] = {
{
.mode = {
@@ -294,10 +286,6 @@ static struct i2c_board_info eukrea_mbimx27_i2c_devices[] = {
},
};
-static struct platform_device *platform_devices[] __initdata = {
- &leds_gpio,
-};
-
static const struct imxmmc_platform_data sdhc_pdata __initconst = {
.dat3_card_detect = 1,
};
@@ -378,5 +366,5 @@ void __init eukrea_mbimx27_baseboard_init(void)
imx27_add_imx_keypad(&eukrea_mbimx27_keymap_data);
- platform_add_devices(platform_devices, ARRAY_SIZE(platform_devices));
+ gpio_led_register_device(-1, &gpio_led_info);
}
--
1.7.4.1
next prev parent reply other threads:[~2011-05-10 8:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110405073030.GI13963@pengutronix.de>
2011-04-05 8:37 ` [PATCH] leds: provide helper to register "leds-gpio" devices Uwe Kleine-König
2011-04-05 16:13 ` Fabio Estevam
2011-04-05 16:29 ` Fabio Estevam
2011-04-05 18:12 ` H Hartley Sweeten
2011-04-05 16:33 ` Russell King - ARM Linux
2011-04-05 20:24 ` [PATCH v2] " Uwe Kleine-König
2011-04-06 11:45 ` Fabio Estevam
2011-04-06 11:52 ` Richard Purdie
2011-04-06 12:33 ` Uwe Kleine-König
2011-04-06 13:38 ` Richard Purdie
2011-04-11 20:35 ` [PATCH v3] " Uwe Kleine-König
2011-04-12 21:48 ` Russell King - ARM Linux
2011-04-13 6:23 ` Uwe Kleine-König
2011-05-06 21:03 ` Richard Purdie
2011-05-09 8:00 ` Uwe Kleine-König
2011-04-26 15:08 ` Uwe Kleine-König
2011-05-06 8:25 ` Uwe Kleine-König
2011-05-09 22:02 ` Andrew Morton
2011-05-09 22:17 ` Russell King - ARM Linux
2011-05-10 6:45 ` Uwe Kleine-König
2011-05-10 7:31 ` Uwe Kleine-König
2011-05-10 8:50 ` [PATCH v4] " Uwe Kleine-König
2011-05-10 8:50 ` Uwe Kleine-König [this message]
2011-05-10 22:26 ` [PATCH] [wip] ARM: imx: register "leds-gpio" device using new helper function H Hartley Sweeten
2011-05-11 6:22 ` Uwe Kleine-König
2011-05-10 23:02 ` H Hartley Sweeten
2011-04-19 23:19 ` [PATCH] leds: provide helper to register "leds-gpio" devices Andrew Morton
2011-04-19 23:24 ` Russell King - ARM Linux
2011-04-19 23:50 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305017456-10910-2-git-send-email-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=fabio.estevam@freescale.com \
--cc=hartleys@visionengravers.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rpurdie@rpsys.net \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).