From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Kaywinnit L. Frye" <kaywinnit.lee.frye.2497@gmail.com>,
linux-kernel@vger.kernel.org,
Michal Nazarewicz <m.nazarewicz@samsung.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Evgeny Kuznetsov <EXT-Eugeny.Kuznetsov@nokia.com>
Subject: Re: [PATCH] wait: include linux/sched.h
Date: Tue, 10 May 2011 13:07:00 +0200 [thread overview]
Message-ID: <1305025620.2914.55.camel@laptop> (raw)
In-Reply-To: <20110510103628.GE2400@elte.hu>
On Tue, 2011-05-10 at 12:36 +0200, Ingo Molnar wrote:
>
> Obviously sched.h would include a lot of basic types to begin with, because it
> is a fundamental 'container' type (struct task_struct) sitting at a top,
> highlevel node of the type hierarchy - so the initial step you suggest would
> indeed get us most of the benefits.
I very well understand the whole header mess, and in particular last
time I looked at the sched.h vs wait.h thing simply removing the non
sched.c related things was enough to resolve this particular problem.
I really don't like the foo_type.h headers much and think we should only
use them as absolute last resort solutions.
I might have mis-read your email, but to me your:
"To fix these super-headers like sched.h and to make wait.h
self-sufficient the right and cleanest approach would be to split data
types and primitive accessor functions.."
Seems to suggest to begin with that split, instead of starting with sane
cleanups like moving the signal and process (groups of tasks) bits out
into their own headers.
next prev parent reply other threads:[~2011-05-10 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 21:34 [PATCH] wait: include linux/sched.h Kaywinnit L. Frye
2011-05-06 7:54 ` Ingo Molnar
2011-05-10 8:11 ` Peter Zijlstra
2011-05-10 10:36 ` Ingo Molnar
2011-05-10 11:07 ` Peter Zijlstra [this message]
2011-05-10 11:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305025620.2914.55.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=EXT-Eugeny.Kuznetsov@nokia.com \
--cc=gregkh@suse.de \
--cc=kaywinnit.lee.frye.2497@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox