From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Niels de Vos <ndevos@redhat.com>,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omap2/omapfb: make DBG() more resistant in if-else constructions
Date: Tue, 10 May 2011 15:08:05 +0300 [thread overview]
Message-ID: <1305029285.2045.38.camel@deskari> (raw)
In-Reply-To: <BANLkTinEJZ=fvJmWRkQ7kKyxbFRaJnum7g@mail.gmail.com>
On Tue, 2011-05-10 at 11:42 +0200, Geert Uytterhoeven wrote:
> What about using the standard pr_debug()/dev_dbg() instead?
> With dynamic debug, it can be enabled at run time.
> As a bonus, you get printf()-style format checking if debugging is disabled.
Yes, dev_dbg & co. would be better.
However, one thing I dislike about them is the extra stuff they print.
For example, for omapfb and omapdss dev_dbg will print:
omapfb omapfb: foo
omapdss_dss omapdss_dss: foo
I originally added the debug macros to omapdss to be able to
automatically print the DSS module name, as at that point there was only
one big omapdss device. And I guess I just followed with similar macro
in omapfb also. But I believe both omapdss and omapfb should be changed
to dev_* prints sometime soon.
Tomi
next prev parent reply other threads:[~2011-05-10 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 9:20 [PATCH] omap2/omapfb: make DBG() more resistant in if-else constructions Niels de Vos
2011-05-10 9:37 ` Premi, Sanjeev
2011-05-10 9:42 ` Geert Uytterhoeven
2011-05-10 10:57 ` Niels de Vos
2011-05-10 11:07 ` [PATCH V2] " Niels de Vos
2011-05-10 12:16 ` Tomi Valkeinen
2011-05-10 12:08 ` Tomi Valkeinen [this message]
2011-05-10 12:14 ` [PATCH] " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305029285.2045.38.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ndevos@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox