public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wanlong Gao <wanlong.gao@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-kernel@vger.kernel.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.
Date: Tue, 10 May 2011 20:36:35 +0800	[thread overview]
Message-ID: <1305030995.3140.0.camel@Tux> (raw)
In-Reply-To: <alpine.LNX.2.00.1105101011550.28291@pobox.suse.cz>

在 2011-05-10二的 10:12 +0200,Jiri Kosina写道:
> On Sun, 17 Apr 2011, Wanlong Gao wrote:
> 
> > 
> > 
> > change the "mc13783_regulator_probe" string in the function
> > "mc13783_regulator_probe"
> > to "__func__" for the debug statement be consistent with the style of the rest
> > of
> > the file.
> > 
> > Signed-off-by: Wanlong Gao <wanlong.gao@gmail.com>
> > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > 
> > ---
> >  drivers/regulator/mc13783-regulator.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/regulator/mc13783-regulator.c
> > b/drivers/regulator/mc13783-regulator.c
> > index 23249cb..b8a00c7 100644
> > --- a/drivers/regulator/mc13783-regulator.c
> > +++ b/drivers/regulator/mc13783-regulator.c
> > @@ -341,7 +341,7 @@ static int __devinit mc13783_regulator_probe(struct
> > platform_device *pdev)
> >         struct mc13783_regulator_init_data *init_data;
> >         int i, ret;
> > 
> > -       dev_dbg(&pdev->dev, "mc13783_regulator_probe id %d\n", pdev->id);
> > +       dev_dbg(&pdev->dev, "%s id %d\n", __func__, pdev->id);
> > 
> >         priv = kzalloc(sizeof(*priv) +
> >                         pdata->num_regulators * sizeof(priv->regulators[0]),
> 
> Applied.
> 
> BTW, your mailer is damaging the in-line patches. I have fixed this now, 
> but please fix that for your future submissions.
> 
> Thanks,
> 

Thanks, and I'll fix it next time.

Wanlong Gao


      reply	other threads:[~2011-05-10 12:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-16 15:42 [PATCH]drivers:regulator:change the dev_dbg in the probe function wanlong.gao
2011-04-16 17:54 ` Mark Brown
2011-04-17  0:53   ` [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest Wanlong Gao
2011-04-17  9:19     ` Harry Wei
2011-04-17 10:11       ` Wanlong Gao
     [not found]         ` <BANLkTi=vqFs11=VBk=2jxH+mDY3xBxwj7g@mail.gmail.com>
2011-04-17 10:22           ` Harry Wei
2011-05-10  8:12     ` Jiri Kosina
2011-05-10 12:36       ` Wanlong Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305030995.3140.0.camel@Tux \
    --to=wanlong.gao@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox