The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
	kay.sievers@vrfy.org, johnstul@us.ibm.com,
	davidel@xmailserver.org, virtuoso@slind.org, tglx@linutronix.de,
	chris.friesen@genband.com, kirill@shutemov.name
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/core] timerfd: Allow timers to be cancelled when clock was set
Date: Wed, 11 May 2011 12:23:53 +0200	[thread overview]
Message-ID: <1305109433.2914.208.camel@laptop> (raw)
In-Reply-To: <tip-99ee5315dac6211e972fa3f23bcc9a0343ff58c4@git.kernel.org>

On Mon, 2011-05-02 at 19:44 +0000, tip-bot for Thomas Gleixner wrote:
> Commit-ID:  99ee5315dac6211e972fa3f23bcc9a0343ff58c4
> Gitweb:     http://git.kernel.org/tip/99ee5315dac6211e972fa3f23bcc9a0343ff58c4
> Author:     Thomas Gleixner <tglx@linutronix.de>
> AuthorDate: Wed, 27 Apr 2011 14:16:42 +0200
> Committer:  Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Mon, 2 May 2011 21:39:15 +0200
> 
> timerfd: Allow timers to be cancelled when clock was set
> 
> Some applications must be aware of clock realtime being set
> backward. A simple example is a clock applet which arms a timer for
> the next minute display. If clock realtime is set backward then the
> applet displays a stale time for the amount of time which the clock
> was set backwards. Due to that applications poll the time because we
> don't have an interface.

Shouldn't that clock applet use CLOCK_MONOTONIC for the timer anyway?

Furthermore, weren't there patches to provide clkadjust notifiers? In
which case we can have the app woken up and it can fiddle its own
timers.

> Extend the timerfd interface by adding a flag which puts the timer
> onto a different internal realtime clock. All timers on this clock are
> expired whenever the clock was set.

I don't much like adding random clocks like that, the extra timer base
makes many timer operations more expensive, and I really don't see this
being worth it :/


       reply	other threads:[~2011-05-11 16:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tip-99ee5315dac6211e972fa3f23bcc9a0343ff58c4@git.kernel.org>
2011-05-11 10:23 ` Peter Zijlstra [this message]
2011-05-11 11:58   ` [tip:timers/core] timerfd: Allow timers to be cancelled when clock was set Kay Sievers
2011-05-11 13:45     ` Peter Zijlstra
2011-05-11 13:52       ` Kay Sievers
2011-05-11 14:01         ` Peter Zijlstra
2011-05-11 14:22           ` Kay Sievers
2011-05-11 14:30             ` Peter Zijlstra
2011-05-11 14:32               ` Kay Sievers
2011-05-11 14:48                 ` Peter Zijlstra
2011-05-11 14:53                   ` Kay Sievers
2011-05-11 15:11                     ` Peter Zijlstra
2011-05-11 15:17                       ` Kay Sievers
2011-05-11 15:31                         ` Peter Zijlstra
2011-05-11 15:44                           ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305109433.2914.208.camel@laptop \
    --to=peterz@infradead.org \
    --cc=chris.friesen@genband.com \
    --cc=davidel@xmailserver.org \
    --cc=hpa@zytor.com \
    --cc=johnstul@us.ibm.com \
    --cc=kay.sievers@vrfy.org \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=virtuoso@slind.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox