From: Namhyung Kim <namhyung@gmail.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-throttle: fix typos on struct throtl_grp init code
Date: Wed, 11 May 2011 23:14:02 +0900 [thread overview]
Message-ID: <1305123242.1561.20.camel@leonhard> (raw)
In-Reply-To: <20110511133033.GD31633@redhat.com>
2011-05-11 (수), 09:30 -0400, Vivek Goyal:
> On Wed, May 11, 2011 at 10:20:45PM +0900, Namhyung Kim wrote:
> > s/td/tg/
>
> I think jens would like to have little more changelog than that.
>
OK, let me clarify this first: My first patch was trivial but second one
seems not. AFAICS it could affect when the bps/iops bandwidth change
applies - maybe delayed to next @tg->disptime? - if there are concurrent
cgroup init and limit change tasks, right? Or do you have something need
to be included in the changelog?
> Otherwise looks good to me.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
>
> Vivek
Thank you for the review and the comment.
--
Regards,
Namhyung Kim
next prev parent reply other threads:[~2011-05-11 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 13:01 [PATCH] blk-throttle: fix a typo in blk_throtl_init() Namhyung Kim
2011-05-11 13:07 ` Vivek Goyal
2011-05-11 13:20 ` [PATCH] blk-throttle: fix typos on struct throtl_grp init code Namhyung Kim
2011-05-11 13:30 ` Vivek Goyal
2011-05-11 14:14 ` Namhyung Kim [this message]
2011-05-11 14:28 ` Vivek Goyal
2011-05-11 14:38 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305123242.1561.20.camel@leonhard \
--to=namhyung@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox