linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: [PATCH v1 2/5] x86, perf: add constraints for architectural PMU v1
Date: Wed, 11 May 2011 11:55:30 -0400	[thread overview]
Message-ID: <1305129333-7456-3-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1305129333-7456-1-git-send-email-avi@redhat.com>

The v1 PMU does not have any fixed counters.  Using the v2 constraints,
which do have fixed counters, causes an additional choice to be present
in the weight calculation, but not when actually scheduling the event,
leading to an event being not scheduled at all.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 arch/x86/kernel/cpu/perf_event_intel.c |   23 ++++++++++++++++++-----
 1 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
index 41178c8..b46b70e 100644
--- a/arch/x86/kernel/cpu/perf_event_intel.c
+++ b/arch/x86/kernel/cpu/perf_event_intel.c
@@ -137,6 +137,11 @@ static struct event_constraint intel_westmere_percore_constraints[] __read_mostl
 	EVENT_CONSTRAINT_END
 };
 
+static struct event_constraint intel_v1_event_constraints[] __read_mostly =
+{
+	EVENT_CONSTRAINT_END
+};
+
 static struct event_constraint intel_gen_event_constraints[] __read_mostly =
 {
 	FIXED_EVENT_CONSTRAINT(0x00c0, 0), /* INST_RETIRED.ANY */
@@ -1512,11 +1517,19 @@ static __init int intel_pmu_init(void)
 		break;
 
 	default:
-		/*
-		 * default constraints for v2 and up
-		 */
-		x86_pmu.event_constraints = intel_gen_event_constraints;
-		pr_cont("generic architected perfmon, ");
+		switch (x86_pmu.version) {
+		case 1:
+			x86_pmu.event_constraints = intel_v1_event_constraints;
+			pr_cont("generic architected perfmon v1, ");
+			break;
+		default:
+			/*
+			 * default constraints for v2 and up
+			 */
+			x86_pmu.event_constraints = intel_gen_event_constraints;
+			pr_cont("generic architected perfmon, ");
+			break;
+		}
 	}
 	return 0;
 }
-- 
1.7.4.3


  parent reply	other threads:[~2011-05-11 15:55 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11 15:55 [PATCH v1 0/5] KVM in-guest performance monitoring Avi Kivity
2011-05-11 15:55 ` [PATCH v1 1/5] perf: add context parameter to perf_event overflow handler Avi Kivity
2011-06-03 14:41   ` Peter Zijlstra
2011-06-05  8:07     ` Avi Kivity
2011-05-11 15:55 ` Avi Kivity [this message]
2011-05-11 15:55 ` [PATCH v1 3/5] perf: export perf_event_refresh() to modules Avi Kivity
2011-05-11 15:55 ` [PATCH v1 4/5] KVM: Expose kvm_lapic_local_deliver() Avi Kivity
2011-05-11 15:55 ` [PATCH v1 5/5] KVM: Expose a version 1 architectural PMU to guests Avi Kivity
2011-05-17 19:41   ` Ingo Molnar
2011-05-18  9:03     ` Avi Kivity
2011-05-18 11:07       ` Ingo Molnar
2011-05-18 11:29         ` Peter Zijlstra
2011-05-18 11:57           ` Ingo Molnar
2011-05-18 11:32         ` Peter Zijlstra
2011-05-18 11:37           ` Avi Kivity
2011-05-18 12:35             ` Peter Zijlstra
2011-05-18 12:49               ` Avi Kivity
2011-06-03 14:41   ` Peter Zijlstra
2011-06-05  8:12     ` Avi Kivity
2011-06-03 14:41   ` Peter Zijlstra
2011-06-05  8:12     ` Avi Kivity
2011-05-12  9:33 ` [PATCH v1 0/5] KVM in-guest performance monitoring Joerg Roedel
2011-05-12  9:47   ` Jan Kiszka
2011-05-12  9:53     ` Avi Kivity
2011-05-12 13:11     ` Joerg Roedel
2011-05-12 13:23       ` Jan Kiszka
2011-05-12 13:43         ` Joerg Roedel
2011-05-12 13:31       ` Avi Kivity
2011-05-12 14:24         ` Joerg Roedel
2011-05-12 14:37           ` Avi Kivity
2011-05-12 14:45             ` Avi Kivity
2011-05-13 12:34             ` Joerg Roedel
2011-05-12  9:51   ` Avi Kivity
2011-05-12 13:06     ` Joerg Roedel
2011-05-12 13:38       ` Avi Kivity
2011-05-12 14:29         ` Joerg Roedel
2011-05-17  9:52 ` Avi Kivity
2011-06-01  9:45   ` Avi Kivity
2011-06-01 10:26     ` Peter Zijlstra
2011-06-01 11:26       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305129333-7456-3-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).